2021-03-16 16:20:58

by Geert Uytterhoeven

Subject: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally

Merely enabling compile-testing should not enable additional code.
To fix this, restrict the automatic enabling of BCM4908_ENET to
ARCH_BCM4908.

Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
v2:
- Enable by default if ARCH_BCM4908.
---
drivers/net/ethernet/broadcom/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index f8a168b73307c03b..cb88ffb8f12fa7ef 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -54,7 +54,7 @@ config B44_PCI
config BCM4908_ENET
tristate "Broadcom BCM4908 internal mac support"
depends on ARCH_BCM4908 || COMPILE_TEST
- default y
+ default y if ARCH_BCM4908
help
This driver supports Ethernet controller integrated into Broadcom
BCM4908 family SoCs.
--
2.25.1

2021-03-16 20:53:59

by Florian Fainelli

Subject: Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally

On 3/16/2021 7:03 AM, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2021-03-16 22:59:41

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Tue, 16 Mar 2021 15:03:41 +0100 you wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908 controller driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally
https://git.kernel.org/netdev/net/c/a3bc48321665

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-03-17 01:12:54

by Rafał Miłecki

Subject: Re: [PATCH v2] net: broadcom: BCM4908_ENET should not default to y, unconditionally

On 2021-03-16 15:03, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional code.
> To fix this, restrict the automatic enabling of BCM4908_ENET to
> ARCH_BCM4908.
>
> Fixes: 4feffeadbcb2e5b1 ("net: broadcom: bcm4908enet: add BCM4908
> controller driver")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Acked-by: Rafał Miłecki <[email protected]>