2021-03-18 08:53:33

by Lee Jones

[permalink] [raw]
Subject: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

This is set 2 out of 2 sets required.

Lee Jones (15):
ata: pata_pdc202xx_old: Fix some incorrectly named functions
ata: pata_sil680: Add some missing function parameter docs
ata: pata_sis: Remove superfluous param description and supply another
ata: pata_triflex: Repair some misnamed functions and fix some param
descriptions
ata: pata_it821x: Fix possible doc-rotted function names
ata: pata_via: Fix a kernel-doc formatting issue
ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
ata: pata_sl82c105: Fix potential doc-rot
ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
ata: pata_legacy: Repair a couple kernel-doc problems
ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'
ata: libata-acpi: Fix function name and provide description for
'prev_gtf'
ata: pata_acpi: Fix some incorrect function param descriptions

drivers/ata/ata_generic.c | 2 +-
drivers/ata/libata-acpi.c | 3 ++-
drivers/ata/pata_acpi.c | 6 +++---
drivers/ata/pata_cs5530.c | 2 +-
drivers/ata/pata_it821x.c | 4 ++--
drivers/ata/pata_legacy.c | 8 ++++----
drivers/ata/pata_opti.c | 2 +-
drivers/ata/pata_pdc202xx_old.c | 4 ++--
drivers/ata/pata_piccolo.c | 2 +-
drivers/ata/pata_sil680.c | 2 ++
drivers/ata/pata_sis.c | 2 +-
drivers/ata/pata_sl82c105.c | 2 +-
drivers/ata/pata_triflex.c | 7 +++----
drivers/ata/pata_via.c | 2 +-
drivers/ata/sata_mv.c | 2 +-
15 files changed, 26 insertions(+), 24 deletions(-)

Cc: Alan Cox <[email protected]>
Cc: ALWAYS copy <[email protected]>
Cc: Andre Hedrick <[email protected]>
Cc: Colten Edwards <[email protected]>
Cc: Hat Inc <[email protected]>
Cc: Jan Harkes <[email protected]>
Cc: Jaromir Koutek <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: "L.C. Chang" <[email protected]>
Cc: [email protected]
Cc: Lionel Bouton <[email protected]>
Cc: Mark Lord <[email protected]>
Cc: Red Hat <[email protected]>
Cc: Samuel Thibault <[email protected]>
Cc: Torben Mathiasen <[email protected]>
Cc: Vojtech Pavlik <[email protected]>
--
2.27.0


2021-03-18 08:53:34

by Lee Jones

[permalink] [raw]
Subject: [PATCH 02/15] ata: pata_sil680: Add some missing function parameter docs

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_sil680.c:68: warning: Function parameter or member 'adev' not described in 'sil680_seldev'
drivers/ata/pata_sil680.c:254: warning: Function parameter or member 'try_mmio' not described in 'sil680_init_chip'

Cc: Jens Axboe <[email protected]>
Cc: Andre Hedrick <[email protected]>
Cc: Red Hat <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_sil680.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/ata/pata_sil680.c b/drivers/ata/pata_sil680.c
index 7ab9aea3b6305..43215a664b960 100644
--- a/drivers/ata/pata_sil680.c
+++ b/drivers/ata/pata_sil680.c
@@ -57,6 +57,7 @@ static unsigned long sil680_selreg(struct ata_port *ap, int r)
/**
* sil680_seldev - return register base
* @ap: ATA interface
+ * @adev: ATA device
* @r: config offset
*
* Turn a config register offset into the right address in PCI space
@@ -244,6 +245,7 @@ static struct ata_port_operations sil680_port_ops = {
/**
* sil680_init_chip - chip setup
* @pdev: PCI device
+ * @try_mmio: Indicates to caller whether MMIO should be attempted
*
* Perform all the chip setup which must be done both when the device
* is powered up on boot and when we resume in case we resumed from RAM.
--
2.27.0

2021-03-18 08:53:39

by Lee Jones

[permalink] [raw]
Subject: [PATCH 03/15] ata: pata_sis: Remove superfluous param description and supply another

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_sis.c:124: warning: Excess function parameter 'deadline' description in 'sis_133_cable_detect'
drivers/ata/pata_sis.c:529: warning: Function parameter or member 'mask' not described in 'sis_133_mode_filter'

Cc: Jens Axboe <[email protected]>
Cc: Andre Hedrick <[email protected]>
Cc: Lionel Bouton <[email protected]>
Cc: Vojtech Pavlik <[email protected]>
Cc: "L.C. Chang" <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_sis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c
index d7cd39a9888a9..b5b764e18adfc 100644
--- a/drivers/ata/pata_sis.c
+++ b/drivers/ata/pata_sis.c
@@ -114,7 +114,6 @@ static int sis_port_base(struct ata_device *adev)
/**
* sis_133_cable_detect - check for 40/80 pin
* @ap: Port
- * @deadline: deadline jiffies for the operation
*
* Perform cable detection for the later UDMA133 capable
* SiS chipset.
@@ -521,6 +520,7 @@ static void sis_133_set_dmamode (struct ata_port *ap, struct ata_device *adev)
/**
* sis_133_mode_filter - mode selection filter
* @adev: ATA device
+ * @mask: received mask to manipulate and pass back
*
* Block UDMA6 on devices that do not support it.
*/
--
2.27.0

2021-03-18 08:53:56

by Lee Jones

[permalink] [raw]
Subject: [PATCH 08/15] ata: pata_sl82c105: Fix potential doc-rot

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_sl82c105.c:191: warning: expecting prototype for sl82c105_bmdma_end(). Prototype was for sl82c105_bmdma_stop() instead

Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_sl82c105.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_sl82c105.c b/drivers/ata/pata_sl82c105.c
index ac7ddd87f188d..8487470e2e01e 100644
--- a/drivers/ata/pata_sl82c105.c
+++ b/drivers/ata/pata_sl82c105.c
@@ -173,7 +173,7 @@ static void sl82c105_bmdma_start(struct ata_queued_cmd *qc)
}

/**
- * sl82c105_bmdma_end - DMA engine stop
+ * sl82c105_bmdma_stop - DMA engine stop
* @qc: ATA command
*
* Reset the DMA engine each use as recommended by the errata
--
2.27.0

2021-03-18 08:53:59

by Lee Jones

[permalink] [raw]
Subject: [PATCH 11/15] ata: pata_legacy: Repair a couple kernel-doc problems

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_legacy.c:606: warning: expecting prototype for opt82c465mv_qc_issue(). Prototype was for opti82c46x_qc_issue() instead
drivers/ata/pata_legacy.c:933: warning: Function parameter or member 'probe' not described in 'legacy_init_one'
drivers/ata/pata_legacy.c:933: warning: Excess function parameter 'pl' description in 'legacy_init_one'
drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'primary' not described in 'legacy_check_special_cases'
drivers/ata/pata_legacy.c:1024: warning: Function parameter or member 'secondary' not described in 'legacy_check_special_cases'
drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases'
drivers/ata/pata_legacy.c:1024: warning: Excess function parameter 'master' description in 'legacy_check_special_cases'

Cc: Jens Axboe <[email protected]>
Cc: Colten Edwards <[email protected]>
Cc: Samuel Thibault <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_legacy.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/pata_legacy.c b/drivers/ata/pata_legacy.c
index 4fd12b20df239..a7235bde6ae87 100644
--- a/drivers/ata/pata_legacy.c
+++ b/drivers/ata/pata_legacy.c
@@ -588,7 +588,7 @@ static void opti82c46x_set_piomode(struct ata_port *ap, struct ata_device *adev)
}

/**
- * opt82c465mv_qc_issue - command issue
+ * opti82c46x_qc_issue - command issue
* @qc: command pending
*
* Called when the libata layer is about to issue a command. We wrap
@@ -923,7 +923,7 @@ static __init int probe_chip_type(struct legacy_probe *probe)

/**
* legacy_init_one - attach a legacy interface
- * @pl: probe record
+ * @probe: probe record
*
* Register an ISA bus IDE interface. Such interfaces are PIO and we
* assume do not support IRQ sharing.
@@ -1009,8 +1009,8 @@ static __init int legacy_init_one(struct legacy_probe *probe)
/**
* legacy_check_special_cases - ATA special cases
* @p: PCI device to check
- * @master: set this if we find an ATA master
- * @master: set this if we find an ATA secondary
+ * @primary: set this if we find an ATA master
+ * @secondary: set this if we find an ATA secondary
*
* A small number of vendors implemented early PCI ATA interfaces
* on bridge logic without the ATA interface being PCI visible.
--
2.27.0

2021-03-18 08:54:06

by Lee Jones

[permalink] [raw]
Subject: [PATCH 09/15] ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_opti.c:82: warning: Function parameter or member 'val' not described in 'opti_write_reg'
drivers/ata/pata_opti.c:82: warning: Excess function parameter 'value' description in 'opti_write_reg'

Cc: Jens Axboe <[email protected]>
Cc: Jaromir Koutek <[email protected]>
Cc: Jan Harkes <[email protected]>
Cc: Mark Lord <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_opti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_opti.c b/drivers/ata/pata_opti.c
index 06a800a3b0706..01976c4e40330 100644
--- a/drivers/ata/pata_opti.c
+++ b/drivers/ata/pata_opti.c
@@ -69,7 +69,7 @@ static int opti_pre_reset(struct ata_link *link, unsigned long deadline)
/**
* opti_write_reg - control register setup
* @ap: ATA port
- * @value: value
+ * @val: value
* @reg: control register number
*
* The Opti uses magic 'trapdoor' register accesses to do configuration
--
2.27.0

2021-03-18 08:54:06

by Lee Jones

[permalink] [raw]
Subject: [PATCH 06/15] ata: pata_via: Fix a kernel-doc formatting issue

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_via.c:675: warning: Function parameter or member 'pdev' not described in 'via_reinit_one'

Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_via.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_via.c b/drivers/ata/pata_via.c
index 38044e6797951..4750320489843 100644
--- a/drivers/ata/pata_via.c
+++ b/drivers/ata/pata_via.c
@@ -663,7 +663,7 @@ static int via_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
#ifdef CONFIG_PM_SLEEP
/**
* via_reinit_one - reinit after resume
- * @pdev; PCI device
+ * @pdev: PCI device
*
* Called when the VIA PATA device is resumed. We must then
* reconfigure the fifo and other setup we may have altered. In
--
2.27.0

2021-03-18 08:54:42

by Lee Jones

[permalink] [raw]
Subject: [PATCH 15/15] ata: pata_acpi: Fix some incorrect function param descriptions

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_acpi.c:38: warning: Function parameter or member 'link' not described in 'pacpi_pre_reset'
drivers/ata/pata_acpi.c:38: warning: Excess function parameter 'ap' description in 'pacpi_pre_reset'
drivers/ata/pata_acpi.c:74: warning: Function parameter or member 'ap' not described in 'pacpi_discover_modes'
drivers/ata/pata_acpi.c:74: warning: Excess function parameter 'mask' description in 'pacpi_discover_modes'
drivers/ata/pata_acpi.c:239: warning: Function parameter or member 'id' not described in 'pacpi_init_one'
drivers/ata/pata_acpi.c:239: warning: Excess function parameter 'ent' description in 'pacpi_init_one'

Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_acpi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/pata_acpi.c b/drivers/ata/pata_acpi.c
index fa2bfc344a976..ade4c3eee2304 100644
--- a/drivers/ata/pata_acpi.c
+++ b/drivers/ata/pata_acpi.c
@@ -28,7 +28,7 @@ struct pata_acpi {

/**
* pacpi_pre_reset - check for 40/80 pin
- * @ap: Port
+ * @link: ATA link
* @deadline: deadline jiffies for the operation
*
* Perform the PATA port setup we need.
@@ -63,8 +63,8 @@ static int pacpi_cable_detect(struct ata_port *ap)

/**
* pacpi_discover_modes - filter non ACPI modes
+ * @ap: ATA port
* @adev: ATA device
- * @mask: proposed modes
*
* Try the modes available and see which ones the ACPI method will
* set up sensibly. From this we get a mask of ACPI modes we can use
@@ -224,7 +224,7 @@ static struct ata_port_operations pacpi_ops = {
/**
* pacpi_init_one - Register ACPI ATA PCI device with kernel services
* @pdev: PCI device to register
- * @ent: Entry in pacpi_pci_tbl matching with @pdev
+ * @id: PCI device ID
*
* Called from kernel PCI layer.
*
--
2.27.0

2021-03-18 08:55:12

by Lee Jones

[permalink] [raw]
Subject: [PATCH 13/15] ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'

Fixes the following W=1 kernel build warning(s):

drivers/ata/sata_mv.c:1929: warning: expecting prototype for mv_bmdma_stop(). Prototype was for mv_bmdma_stop_ap() instead

Cc: Jens Axboe <[email protected]>
Cc: Mark Lord <[email protected]>
Cc: ALWAYS copy <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/sata_mv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
index eafca46d8feb4..bd23d63435cb4 100644
--- a/drivers/ata/sata_mv.c
+++ b/drivers/ata/sata_mv.c
@@ -1917,7 +1917,7 @@ static void mv_bmdma_start(struct ata_queued_cmd *qc)
}

/**
- * mv_bmdma_stop - Stop BMDMA transfer
+ * mv_bmdma_stop_ap - Stop BMDMA transfer
* @ap: port to stop
*
* Clears the ATA_DMA_START flag in the bmdma control register
--
2.27.0

2021-03-18 08:55:36

by Lee Jones

[permalink] [raw]
Subject: [PATCH 05/15] ata: pata_it821x: Fix possible doc-rotted function names

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_it821x.c:346: warning: expecting prototype for it821x_passthru_dma_start(). Prototype was for it821x_passthru_bmdma_start() instead
drivers/ata/pata_it821x.c:369: warning: expecting prototype for it821x_passthru_dma_stop(). Prototype was for it821x_passthru_bmdma_stop() instead

Cc: Jens Axboe <[email protected]>
Cc: Alan Cox <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_it821x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/pata_it821x.c b/drivers/ata/pata_it821x.c
index 9bac79edbc2ce..0e2265978a34e 100644
--- a/drivers/ata/pata_it821x.c
+++ b/drivers/ata/pata_it821x.c
@@ -334,7 +334,7 @@ static void it821x_passthru_set_dmamode(struct ata_port *ap, struct ata_device *
}

/**
- * it821x_passthru_dma_start - DMA start callback
+ * it821x_passthru_bmdma_start - DMA start callback
* @qc: Command in progress
*
* Usually drivers set the DMA timing at the point the set_dmamode call
@@ -357,7 +357,7 @@ static void it821x_passthru_bmdma_start(struct ata_queued_cmd *qc)
}

/**
- * it821x_passthru_dma_stop - DMA stop callback
+ * it821x_passthru_bmdma_stop - DMA stop callback
* @qc: ATA command
*
* We loaded new timings in dma_start, as a result we need to restore
--
2.27.0

2021-03-18 08:55:39

by Lee Jones

[permalink] [raw]
Subject: [PATCH 04/15] ata: pata_triflex: Repair some misnamed functions and fix some param descriptions

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_triflex.c:143: warning: expecting prototype for triflex_dma_start(). Prototype was for triflex_bmdma_start() instead
drivers/ata/pata_triflex.c:159: warning: Function parameter or member 'qc' not described in 'triflex_bmdma_stop'
drivers/ata/pata_triflex.c:159: warning: expecting prototype for triflex_dma_stop(). Prototype was for triflex_bmdma_stop() instead

Cc: Jens Axboe <[email protected]>
Cc: Alan Cox <[email protected]>
Cc: Torben Mathiasen <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_triflex.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/pata_triflex.c b/drivers/ata/pata_triflex.c
index 2a4d38b980261..8a033598e7e17 100644
--- a/drivers/ata/pata_triflex.c
+++ b/drivers/ata/pata_triflex.c
@@ -129,7 +129,7 @@ static void triflex_set_piomode(struct ata_port *ap, struct ata_device *adev)
}

/**
- * triflex_dma_start - DMA start callback
+ * triflex_bmdma_start - DMA start callback
* @qc: Command in progress
*
* Usually drivers set the DMA timing at the point the set_dmamode call
@@ -146,9 +146,8 @@ static void triflex_bmdma_start(struct ata_queued_cmd *qc)
}

/**
- * triflex_dma_stop - DMA stop callback
- * @ap: ATA interface
- * @adev: ATA device
+ * triflex_bmdma_stop - DMA stop callback
+ * @qc: ATA command
*
* We loaded new timings in dma_start, as a result we need to restore
* the PIO timings in dma_stop so that the next command issue gets the
--
2.27.0

2021-03-18 08:55:51

by Lee Jones

[permalink] [raw]
Subject: [PATCH 07/15] ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_piccolo.c:87: warning: expecting prototype for ata_tosh_init(). Prototype was for ata_tosh_init_one() instead

Cc: Jens Axboe <[email protected]>
Cc: Andre Hedrick <[email protected]>
Cc: Hat Inc <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_piccolo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_piccolo.c b/drivers/ata/pata_piccolo.c
index 35cb0e2632379..389b63b13c706 100644
--- a/drivers/ata/pata_piccolo.c
+++ b/drivers/ata/pata_piccolo.c
@@ -74,7 +74,7 @@ static struct ata_port_operations tosh_port_ops = {
};

/**
- * ata_tosh_init - attach generic IDE
+ * ata_tosh_init_one - attach generic IDE
* @dev: PCI device found
* @id: match entry
*
--
2.27.0

2021-03-18 08:55:56

by Lee Jones

[permalink] [raw]
Subject: [PATCH 10/15] ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'

Fixes the following W=1 kernel build warning(s):

drivers/ata/ata_generic.c:164: warning: expecting prototype for ata_generic_init(). Prototype was for ata_generic_init_one() instead

Cc: Jens Axboe <[email protected]>
Cc: Andre Hedrick <[email protected]>
Cc: Hat Inc <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/ata_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ata_generic.c b/drivers/ata/ata_generic.c
index 9ff545ce8da3e..20a32e4d501d3 100644
--- a/drivers/ata/ata_generic.c
+++ b/drivers/ata/ata_generic.c
@@ -151,7 +151,7 @@ static int is_intel_ider(struct pci_dev *dev)
}

/**
- * ata_generic_init - attach generic IDE
+ * ata_generic_init_one - attach generic IDE
* @dev: PCI device found
* @id: match entry
*
--
2.27.0

2021-03-18 08:56:19

by Lee Jones

[permalink] [raw]
Subject: [PATCH 12/15] ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param

Fixes the following W=1 kernel build warning(s):

drivers/ata/pata_cs5530.c:283: warning: Function parameter or member 'pdev' not described in 'cs5530_init_one'
drivers/ata/pata_cs5530.c:283: warning: Excess function parameter 'dev' description in 'cs5530_init_one'

Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/pata_cs5530.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_cs5530.c b/drivers/ata/pata_cs5530.c
index ad75d02b6dacf..a1b4aaccaa50a 100644
--- a/drivers/ata/pata_cs5530.c
+++ b/drivers/ata/pata_cs5530.c
@@ -271,7 +271,7 @@ static int cs5530_init_chip(void)

/**
* cs5530_init_one - Initialise a CS5530
- * @dev: PCI device
+ * @pdev: PCI device
* @id: Entry in match table
*
* Install a driver for the newly found CS5530 companion chip. Most of
--
2.27.0

2021-03-18 08:56:35

by Lee Jones

[permalink] [raw]
Subject: [PATCH 14/15] ata: libata-acpi: Fix function name and provide description for 'prev_gtf'

Fixes the following W=1 kernel build warning(s):

drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead
drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf'

Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Signed-off-by: Lee Jones <[email protected]>
---
drivers/ata/libata-acpi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 224e3486e9a5d..7a7d6642edcc5 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -476,7 +476,7 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf)
}

/**
- * ata_acpi_gtm_xfermode - determine xfermode from GTM parameter
+ * ata_acpi_gtm_xfermask - determine xfermode from GTM parameter
* @dev: target device
* @gtm: GTM parameter to use
*
@@ -624,6 +624,7 @@ static int ata_acpi_filter_tf(struct ata_device *dev,
* ata_acpi_run_tf - send taskfile registers to host controller
* @dev: target ATA device
* @gtf: raw ATA taskfile register set (0x1f1 - 0x1f7)
+ * @prev_gtf: previous command
*
* Outputs ATA taskfile to standard ATA host controller.
* Writes the control, feature, nsect, lbal, lbam, and lbah registers.
--
2.27.0

2021-03-30 13:23:03

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

On Thu, 18 Mar 2021, Lee Jones wrote:

> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is set 2 out of 2 sets required.
>
> Lee Jones (15):
> ata: pata_pdc202xx_old: Fix some incorrectly named functions
> ata: pata_sil680: Add some missing function parameter docs
> ata: pata_sis: Remove superfluous param description and supply another
> ata: pata_triflex: Repair some misnamed functions and fix some param
> descriptions
> ata: pata_it821x: Fix possible doc-rotted function names
> ata: pata_via: Fix a kernel-doc formatting issue
> ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header
> ata: pata_sl82c105: Fix potential doc-rot
> ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()'
> ata: ata_generic: Fix misspelling of 'ata_generic_init_one()'
> ata: pata_legacy: Repair a couple kernel-doc problems
> ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param
> ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()'
> ata: libata-acpi: Fix function name and provide description for
> 'prev_gtf'
> ata: pata_acpi: Fix some incorrect function param descriptions

Would you like me to resubmit these?

> drivers/ata/ata_generic.c | 2 +-
> drivers/ata/libata-acpi.c | 3 ++-
> drivers/ata/pata_acpi.c | 6 +++---
> drivers/ata/pata_cs5530.c | 2 +-
> drivers/ata/pata_it821x.c | 4 ++--
> drivers/ata/pata_legacy.c | 8 ++++----
> drivers/ata/pata_opti.c | 2 +-
> drivers/ata/pata_pdc202xx_old.c | 4 ++--
> drivers/ata/pata_piccolo.c | 2 +-
> drivers/ata/pata_sil680.c | 2 ++
> drivers/ata/pata_sis.c | 2 +-
> drivers/ata/pata_sl82c105.c | 2 +-
> drivers/ata/pata_triflex.c | 7 +++----
> drivers/ata/pata_via.c | 2 +-
> drivers/ata/sata_mv.c | 2 +-
> 15 files changed, 26 insertions(+), 24 deletions(-)
>
> Cc: Alan Cox <[email protected]>
> Cc: ALWAYS copy <[email protected]>
> Cc: Andre Hedrick <[email protected]>
> Cc: Colten Edwards <[email protected]>
> Cc: Hat Inc <[email protected]>
> Cc: Jan Harkes <[email protected]>
> Cc: Jaromir Koutek <[email protected]>
> Cc: Jens Axboe <[email protected]>
> Cc: "L.C. Chang" <[email protected]>
> Cc: [email protected]
> Cc: Lionel Bouton <[email protected]>
> Cc: Mark Lord <[email protected]>
> Cc: Red Hat <[email protected]>
> Cc: Samuel Thibault <[email protected]>
> Cc: Torben Mathiasen <[email protected]>
> Cc: Vojtech Pavlik <[email protected]>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

2021-03-31 02:23:34

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA

On 3/18/21 2:51 AM, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> This is set 2 out of 2 sets required.

Applied, thanks.

--
Jens Axboe