2021-03-22 12:31:14

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] drivers: scsi: Remove duplicate include of blkdev.h

linux/blkdev.h has been included at line 18, so remove
the duplicate include at line 27.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c86760788c72..e8aa7de17d0a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -24,7 +24,6 @@
#include "ufs_bsg.h"
#include "ufshcd-crypto.h"
#include <asm/unaligned.h>
-#include <linux/blkdev.h>

#define CREATE_TRACE_POINTS
#include <trace/events/ufs.h>
--
2.25.1


2021-03-23 04:28:22

by Can Guo

[permalink] [raw]
Subject: Re: [PATCH] drivers: scsi: Remove duplicate include of blkdev.h

On 2021-03-22 20:28, Wan Jiabing wrote:
> linux/blkdev.h has been included at line 18, so remove
> the duplicate include at line 27.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index c86760788c72..e8aa7de17d0a 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -24,7 +24,6 @@
> #include "ufs_bsg.h"
> #include "ufshcd-crypto.h"
> #include <asm/unaligned.h>
> -#include <linux/blkdev.h>
>
> #define CREATE_TRACE_POINTS
> #include <trace/events/ufs.h>

Someone has addressed it before you - check
https://git.kernel.org/mkp/scsi/c/b4388e3db56a

Can Guo.