2021-03-22 12:57:42

by Jiabing Wan

Subject: [PATCH] drivers: gpu: priv.h is included twice

priv.h has been included at line 22, so remove
the duplicate include at line 24.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
index c39e797dc7c9..09524168431c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
@@ -20,8 +20,6 @@
* OTHER DEALINGS IN THE SOFTWARE.
*/
#include "priv.h"
-
-#include "priv.h"
#include <core/firmware.h>

static void *
--
2.25.1

2021-03-23 17:24:37

by Lyude Paul

Subject: Re: [PATCH] drivers: gpu: priv.h is included twice

Reviewed-by: Lyude Paul <[email protected]>

On Mon, 2021-03-22 at 20:45 +0800, Wan Jiabing wrote:
> priv.h has been included at line 22, so remove
> the duplicate include at line 24.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> index c39e797dc7c9..09524168431c 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/nvenc/base.c
> @@ -20,8 +20,6 @@
>   * OTHER DEALINGS IN THE SOFTWARE.
>   */
>  #include "priv.h"
> -
> -#include "priv.h"
>  #include <core/firmware.h>
>  
>  static void *

--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat

Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!