2021-03-23 03:16:07

by Jiabing Wan

Subject: [PATCH] include: linux: Remove duplicate include of pgtable.h

linux/pgtable.h has been included at line 11 with annotation.
So we remove the duplicate one at line 8.

Signed-off-by: Wan Jiabing <[email protected]>
---
include/linux/crash_dump.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b718dbe..be79a45d7aa3 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -5,7 +5,6 @@
#include <linux/kexec.h>
#include <linux/proc_fs.h>
#include <linux/elf.h>
-#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>

#include <linux/pgtable.h> /* for pgprot_t */
--
2.25.1

2021-03-23 07:59:03

by Baoquan He

Subject: Re: [PATCH] include: linux: Remove duplicate include of pgtable.h

On 03/23/21 at 11:13am, Wan Jiabing wrote:
> linux/pgtable.h has been included at line 11 with annotation.
> So we remove the duplicate one at line 8.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Thanks for your posting. But this resend is still not good. I have
pasted the suggested log, wondering why you just ignore it and send v2
without updating, and also not marking this is v2. Please read
Documentation/process/submitting-patches.rst before you post next time.
Anyway, I have ack-ed Tian Tao's patch since his patch log is good
enough.

Thanks
Baoquan

> ---
> include/linux/crash_dump.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..be79a45d7aa3 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -5,7 +5,6 @@
> #include <linux/kexec.h>
> #include <linux/proc_fs.h>
> #include <linux/elf.h>
> -#include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> #include <linux/pgtable.h> /* for pgprot_t */
> --
> 2.25.1
>