2021-03-25 03:08:49

by Bhaskar Chowdhury

[permalink] [raw]

Subject: [PATCH] i2c-stm32f4: Mundane typo fix

---

s/postion/position/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
drivers/i2c/busses/i2c-stm32f4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
index 937c2c8fd349..4933fc8ce3fd 100644
--- a/drivers/i2c/busses/i2c-stm32f4.c
+++ b/drivers/i2c/busses/i2c-stm32f4.c
@@ -534,7 +534,7 @@ static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev)
default:
/*
* N-byte reception:
- * Enable ACK, reset POS (ACK postion) and clear ADDR flag.
+ * Enable ACK, reset POS (ACK position) and clear ADDR flag.
* In that way, ACK will be sent as soon as the current byte
* will be received in the shift register
*/
--
2.30.1

2021-03-25 03:30:02

by Randy Dunlap

[permalink] [raw]

Subject: Re: [PATCH] i2c-stm32f4: Mundane typo fix

---

On 3/24/21 7:06 AM, Bhaskar Chowdhury wrote:
>
> s/postion/position/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Acked-by: Randy Dunlap <[email protected]>

> ---
> drivers/i2c/busses/i2c-stm32f4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 937c2c8fd349..4933fc8ce3fd 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -534,7 +534,7 @@ static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev)
> default:
> /*
> * N-byte reception:
> - * Enable ACK, reset POS (ACK postion) and clear ADDR flag.
> + * Enable ACK, reset POS (ACK position) and clear ADDR flag.
> * In that way, ACK will be sent as soon as the current byte
> * will be received in the shift register
> */
> --


--
~Randy

2021-03-25 07:47:47

by Alain Volmat

[permalink] [raw]

Subject: Re: [PATCH] i2c-stm32f4: Mundane typo fix

---

On Wed, Mar 24, 2021 at 07:36:10PM +0530, Bhaskar Chowdhury wrote:
>
> s/postion/position/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> drivers/i2c/busses/i2c-stm32f4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 937c2c8fd349..4933fc8ce3fd 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -534,7 +534,7 @@ static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev)
> default:
> /*
> * N-byte reception:
> - * Enable ACK, reset POS (ACK postion) and clear ADDR flag.
> + * Enable ACK, reset POS (ACK position) and clear ADDR flag.
> * In that way, ACK will be sent as soon as the current byte
> * will be received in the shift register
> */

Reviewed-by: Alain Volmat <[email protected]>

> --
> 2.30.1
>

2021-03-25 09:26:21

by Pierre Yves MORDRET

[permalink] [raw]

Subject: Re: [PATCH] i2c-stm32f4: Mundane typo fix

---

On 3/25/21 10:19 AM, Pierre Yves MORDRET wrote:
>
> s/postion/position/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> drivers/i2c/busses/i2c-stm32f4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-stm32f4.c b/drivers/i2c/busses/i2c-stm32f4.c
> index 937c2c8fd349..4933fc8ce3fd 100644
> --- a/drivers/i2c/busses/i2c-stm32f4.c
> +++ b/drivers/i2c/busses/i2c-stm32f4.c
> @@ -534,7 +534,7 @@ static void stm32f4_i2c_handle_rx_addr(struct stm32f4_i2c_dev *i2c_dev)
> default:
> /*
> * N-byte reception:
> - * Enable ACK, reset POS (ACK postion) and clear ADDR flag.
> + * Enable ACK, reset POS (ACK position) and clear ADDR flag.
> * In that way, ACK will be sent as soon as the current byte
> * will be received in the shift register
> */

Hi All,

Reviewed-by: Pierre-Yves MORDRET <[email protected]>

> --
> 2.30.1
>

Regards
--
--
~ Py MORDRET
--

2021-03-31 07:57:07

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH] i2c-stm32f4: Mundane typo fix

---

On Wed, Mar 24, 2021 at 07:36:10PM +0530, Bhaskar Chowdhury wrote:
>
> s/postion/position/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>

Applied to for-current, thanks! Please check older commits to this
driver for the proper subject prefix, i.e. "i2c: <driver>" in I2C.

---

Attachments:

(No filename) (299.00 B)
signature.asc (849.00 B)
Download all attachments