2021-03-25 04:41:43

by Jiabing Wan

Subject: [PATCH] tools: perf: util: Remove duplicate declaration

struct evlist has been declared at 10th line.
struct comm has been declared at 15th line.
Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
tools/perf/util/metricgroup.h | 1 -
tools/perf/util/thread-stack.h | 1 -
2 files changed, 2 deletions(-)

diff --git a/tools/perf/util/metricgroup.h b/tools/perf/util/metricgroup.h
index ed1b9392e624..026bbf416c48 100644
--- a/tools/perf/util/metricgroup.h
+++ b/tools/perf/util/metricgroup.h
@@ -9,7 +9,6 @@

struct evlist;
struct evsel;
-struct evlist;
struct option;
struct rblist;
struct pmu_events_map;
diff --git a/tools/perf/util/thread-stack.h b/tools/perf/util/thread-stack.h
index 3bc47a42af8e..b3cd09beb62f 100644
--- a/tools/perf/util/thread-stack.h
+++ b/tools/perf/util/thread-stack.h
@@ -16,7 +16,6 @@ struct comm;
struct ip_callchain;
struct symbol;
struct dso;
-struct comm;
struct perf_sample;
struct addr_location;
struct call_path;
--
2.25.1

2021-03-25 12:04:30

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] tools: perf: util: Remove duplicate declaration

Em Thu, Mar 25, 2021 at 12:39:34PM +0800, Wan Jiabing escreveu:
> struct evlist has been declared at 10th line.
> struct comm has been declared at 15th line.
> Remove the duplicate.

Thanks, applied.

- Arnaldo


> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> tools/perf/util/metricgroup.h | 1 -
> tools/perf/util/thread-stack.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/tools/perf/util/metricgroup.h b/tools/perf/util/metricgroup.h
> index ed1b9392e624..026bbf416c48 100644
> --- a/tools/perf/util/metricgroup.h
> +++ b/tools/perf/util/metricgroup.h
> @@ -9,7 +9,6 @@
>
> struct evlist;
> struct evsel;
> -struct evlist;
> struct option;
> struct rblist;
> struct pmu_events_map;
> diff --git a/tools/perf/util/thread-stack.h b/tools/perf/util/thread-stack.h
> index 3bc47a42af8e..b3cd09beb62f 100644
> --- a/tools/perf/util/thread-stack.h
> +++ b/tools/perf/util/thread-stack.h
> @@ -16,7 +16,6 @@ struct comm;
> struct ip_callchain;
> struct symbol;
> struct dso;
> -struct comm;
> struct perf_sample;
> struct addr_location;
> struct call_path;
> --
> 2.25.1
>

--

- Arnaldo