2021-03-25 04:52:23

by Jiabing Wan

Subject: [PATCH] drivers: gpu: drm: Remove duplicate declaration

struct dss_device has been declared at 51st line.
Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
index a40abeafd2e9..2658aadee09a 100644
--- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
+++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
@@ -52,7 +52,6 @@ struct dss_device;
struct omap_drm_private;
struct omap_dss_device;
struct dispc_device;
-struct dss_device;
struct dss_lcd_mgr_config;
struct snd_aes_iec958;
struct snd_cea_861_aud_if;
--
2.25.1

2021-03-25 09:07:32

by Laurent Pinchart

Subject: Re: [PATCH] drivers: gpu: drm: Remove duplicate declaration

Hi Wan,

Thank you for the patch.

On Thu, Mar 25, 2021 at 12:50:19PM +0800, Wan Jiabing wrote:
> struct dss_device has been declared at 51st line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> index a40abeafd2e9..2658aadee09a 100644
> --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h
> +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h
> @@ -52,7 +52,6 @@ struct dss_device;
> struct omap_drm_private;
> struct omap_dss_device;
> struct dispc_device;
> -struct dss_device;
> struct dss_lcd_mgr_config;
> struct snd_aes_iec958;
> struct snd_cea_861_aud_if;

While at it, could you sort these forward declarations alphabetically,
so that duplicates are easier to see ?

--
Regards,

Laurent Pinchart