2021-03-25 06:30:40

by Jiabing Wan

Subject: [PATCH] drivers: staging: _adapter is declared twice

struct _adapter has been declared at 23rd line.
Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/staging/rtl8712/drv_types.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index 0c4325073c63..976d19cdcf87 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -36,7 +36,6 @@ enum _NIC_VERSION {
RTL8716_NIC
};

-struct _adapter;

struct qos_priv {
/* bit mask option: u-apsd, s-apsd, ts, block ack... */
--
2.25.1

2021-03-25 07:33:48

by Dan Carpenter

Subject: Re: [PATCH] drivers: staging: _adapter is declared twice

On Thu, Mar 25, 2021 at 02:28:40PM +0800, Wan Jiabing wrote:
> struct _adapter has been declared at 23rd line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/staging/rtl8712/drv_types.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
> index 0c4325073c63..976d19cdcf87 100644
> --- a/drivers/staging/rtl8712/drv_types.h
> +++ b/drivers/staging/rtl8712/drv_types.h
> @@ -36,7 +36,6 @@ enum _NIC_VERSION {
> RTL8716_NIC
> };
>
> -struct _adapter;
>
> struct qos_priv {

You need to delete the blank line after it as well to avoid the
checkpatch warning about two blank lines in a row.

regards,
dan carpenter