2021-03-22 03:12:31

by Liu Ying

Subject: [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

LDB channel1 should be registered if it is the only channel to be used.
Without this patch, imx_ldb_bind() would skip registering LDB channel1
if LDB channel0 is not used, no matter LDB channel1 needs to be used or
not.

Fixes: 8767f4711b2b (drm/imx: imx-ldb: move initialization into probe)
Signed-off-by: Liu Ying <[email protected]>
---
This patch fixes an issue introduced in v5.12-rc1.
It would be good to fix sooner than later.

drivers/gpu/drm/imx/imx-ldb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c
index dbfe39e..b794ed4 100644
--- a/drivers/gpu/drm/imx/imx-ldb.c
+++ b/drivers/gpu/drm/imx/imx-ldb.c
@@ -583,7 +583,7 @@ static int imx_ldb_bind(struct device *dev, struct device *master, void *data)
struct imx_ldb_channel *channel = &imx_ldb->channel[i];

if (!channel->ldb)
- break;
+ continue;

ret = imx_ldb_register(drm, channel);
if (ret)
--
2.7.4

2021-03-25 07:09:56

by Philipp Zabel

Subject: Re: [PATCH] drm/imx: imx-ldb: Register LDB channel1 when it is the only channel to be used

On Mon, Mar 22, 2021 at 10:56:40AM +0800, Liu Ying wrote:
> LDB channel1 should be registered if it is the only channel to be used.
> Without this patch, imx_ldb_bind() would skip registering LDB channel1
> if LDB channel0 is not used, no matter LDB channel1 needs to be used or
> not.
>
> Fixes: 8767f4711b2b (drm/imx: imx-ldb: move initialization into probe)
> Signed-off-by: Liu Ying <[email protected]>

Thank you, applied to imx-drm/fixes.

regards
Philipp