2021-03-25 07:46:34

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] [v2] drivers: staging: _adapter is declared twice

struct _adapter has been declared at 23rd line.
Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/staging/rtl8712/drv_types.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index 0c4325073c63..a44d04effc8b 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -36,8 +36,6 @@ enum _NIC_VERSION {
RTL8716_NIC
};

-struct _adapter;
-
struct qos_priv {
/* bit mask option: u-apsd, s-apsd, ts, block ack... */
unsigned int qos_option;
--
2.25.1


2021-03-25 07:51:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] [v2] drivers: staging: _adapter is declared twice

On Thu, Mar 25, 2021 at 03:41:47PM +0800, Wan Jiabing wrote:
> struct _adapter has been declared at 23rd line.

Trailing whitespace :(

> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/staging/rtl8712/drv_types.h | 2 --
> 1 file changed, 2 deletions(-)

If this is a v2 patch, you need to list what you changed below the ---
line as documented.

Please fix up and resend a v3.

thanks,

greg k-h