2021-03-25 15:24:56

by Jiabing Wan

Subject: [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration

struct task_struct has been declared.
Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
Changelog:
v2:
- Remove another duplicate declaration for being closer
to its user.
---
include/linux/debug_locks.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 2915f56ad421..32f6a37a3d3f 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -6,8 +6,6 @@
#include <linux/bug.h>
#include <linux/printk.h>

-struct task_struct;
-
extern int debug_locks __read_mostly;
extern int debug_locks_silent __read_mostly;

--
2.25.1

2021-03-25 15:47:42

by Andy Shevchenko

Subject: Re: [PATCH] [v2] include: linux: debug_locks: Remove duplicate declaration

On Thu, Mar 25, 2021 at 11:20:28PM +0800, Wan Jiabing wrote:
> struct task_struct has been declared.

"...declared twice."

In the subject line the "include: linux: " part is not needed.

FWIW, after addressing above,
Reviewed-by: Andy Shevchenko <[email protected]>

> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> Changelog:
> v2:
> - Remove another duplicate declaration for being closer
> to its user.
> ---
> include/linux/debug_locks.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..32f6a37a3d3f 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -6,8 +6,6 @@
> #include <linux/bug.h>
> #include <linux/printk.h>
>
> -struct task_struct;
> -
> extern int debug_locks __read_mostly;
> extern int debug_locks_silent __read_mostly;
>
> --
> 2.25.1
>

--
With Best Regards,
Andy Shevchenko