2021-03-25 17:49:32

by Colin King

[permalink] [raw]
Subject: [PATCH] mtd: cfi: remove redundant assignment to variable timeo

From: Colin Ian King <[email protected]>

The variable timeo is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c
index 6f6b0265c22d..54926b72c331 100644
--- a/drivers/mtd/chips/cfi_cmdset_0002.c
+++ b/drivers/mtd/chips/cfi_cmdset_0002.c
@@ -1650,7 +1650,7 @@ static int __xipram do_write_oneword_once(struct map_info *map,
unsigned long adr, map_word datum,
int mode, struct cfi_private *cfi)
{
- unsigned long timeo = jiffies + HZ;
+ unsigned long timeo;
/*
* We use a 1ms + 1 jiffies generic timeout for writes (most devices
* have a max write time of a few hundreds usec). However, we should
--
2.30.2


2021-04-14 02:29:58

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH] mtd: cfi: remove redundant assignment to variable timeo

Hi Colin King,

On Thu, 25 Mar 2021 17:45:14 +0000, Colin King wrote:
> The variable timeo is being initialized with a value that is never read
> and it is being updated later with a new value. The initialization is
> redundant and can be removed.

Fixed up $subject prefix to match existing convention for the file.

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git cfi/next, thanks!
[1/1] mtd: cfi: remove redundant assignment to variable timeo
https://git.kernel.org/mtd/c/f3907773d6

--
Regards
Vignesh