2021-03-25 19:33:06

by Al Cooper

Subject: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk

Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
latest chips have this fixed and earlier chips have other
CQE problems that prevent the feature from being enabled.

Signed-off-by: Al Cooper <[email protected]>
---
drivers/mmc/host/sdhci-brcmstb.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
index f9780c65ebe9..f24623aac2db 100644
--- a/drivers/mmc/host/sdhci-brcmstb.c
+++ b/drivers/mmc/host/sdhci-brcmstb.c
@@ -199,7 +199,6 @@ static int sdhci_brcmstb_add_host(struct sdhci_host *host,
if (dma64) {
dev_dbg(mmc_dev(host->mmc), "Using 64 bit DMA\n");
cq_host->caps |= CQHCI_TASK_DESC_SZ_128;
- cq_host->quirks |= CQHCI_QUIRK_SHORT_TXFR_DESC_SZ;
}

ret = cqhci_init(cq_host, host->mmc, dma64);

base-commit: e138138003eb3b3d06cc91cf2e8c5dec77e2a31e
--
2.17.1

2021-03-25 22:36:26

by Florian Fainelli

Subject: Re: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk

On 3/25/2021 12:28 PM, Al Cooper wrote:
> Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
> latest chips have this fixed and earlier chips have other
> CQE problems that prevent the feature from being enabled.
>
> Signed-off-by: Al Cooper <[email protected]>

Acked-by: Florian Fainelli <[email protected]>
--
Florian

2021-03-30 10:47:19

by Ulf Hansson

Subject: Re: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk

On Thu, 25 Mar 2021 at 20:28, Al Cooper <[email protected]> wrote:
>
> Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the
> latest chips have this fixed and earlier chips have other
> CQE problems that prevent the feature from being enabled.
>
> Signed-off-by: Al Cooper <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/sdhci-brcmstb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-brcmstb.c b/drivers/mmc/host/sdhci-brcmstb.c
> index f9780c65ebe9..f24623aac2db 100644
> --- a/drivers/mmc/host/sdhci-brcmstb.c
> +++ b/drivers/mmc/host/sdhci-brcmstb.c
> @@ -199,7 +199,6 @@ static int sdhci_brcmstb_add_host(struct sdhci_host *host,
> if (dma64) {
> dev_dbg(mmc_dev(host->mmc), "Using 64 bit DMA\n");
> cq_host->caps |= CQHCI_TASK_DESC_SZ_128;
> - cq_host->quirks |= CQHCI_QUIRK_SHORT_TXFR_DESC_SZ;
> }
>
> ret = cqhci_init(cq_host, host->mmc, dma64);
>
> base-commit: e138138003eb3b3d06cc91cf2e8c5dec77e2a31e
> --
> 2.17.1
>