2021-03-26 08:07:23

by Xuezhi Zhang

[permalink] [raw]
Subject: [PATCH] staging: fbtft: fix a typo

From: "Carlis" <[email protected]>

Change 'tft' to 'TFT'

Signed-off-by: Carlis <[email protected]>
---
drivers/staging/fbtft/fbtft-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 4f362da..44e7acb 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -775,7 +775,7 @@ void fbtft_framebuffer_release(struct fb_info *info)
EXPORT_SYMBOL(fbtft_framebuffer_release);

/**
- * fbtft_register_framebuffer - registers a tft frame buffer device
+ * fbtft_register_framebuffer - registers a TFT frame buffer device
* @fb_info: frame buffer info structure
*
* Sets SPI driverdata if needed
@@ -873,7 +873,7 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
EXPORT_SYMBOL(fbtft_register_framebuffer);

/**
- * fbtft_unregister_framebuffer - releases a tft frame buffer device
+ * fbtft_unregister_framebuffer - releases a TFT frame buffer device
* @fb_info: frame buffer info structure
*
* Frees SPI driverdata if needed
--
1.9.1


2021-03-26 08:42:26

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: fbtft: fix a typo

On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> From: "Carlis" <[email protected]>
>
> Change 'tft' to 'TFT'

Why? What is wrong with "tft"?

>
> Signed-off-by: Carlis <[email protected]>

Full name please.

thanks,

greg k-h

2021-03-26 09:18:57

by Xuezhi Zhang

[permalink] [raw]
Subject: Re: [PATCH] staging: fbtft: fix a typo

On Fri, 26 Mar 2021 09:37:48 +0100
Greg KH <[email protected]> wrote:

> On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> > From: "Carlis" <[email protected]>
> >
> > Change 'tft' to 'TFT'
>
> Why? What is wrong with "tft"?
>
I think abbreviations should be capitalized.
> >
> > Signed-off-by: Carlis <[email protected]>
>
> Full name please.
>
OK, i will use my full name next patch
> thanks,
>
> greg k-h

2021-03-26 09:36:44

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: fbtft: fix a typo

On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
> On Fri, 26 Mar 2021 09:37:48 +0100
> Greg KH <[email protected]> wrote:
>
> > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> > > From: "Carlis" <[email protected]>
> > >
> > > Change 'tft' to 'TFT'
> >
> > Why? What is wrong with "tft"?
> >
> I think abbreviations should be capitalized.

Why? What requires this?

thanks,

greg k-h

2021-03-26 10:01:38

by Xuezhi Zhang

[permalink] [raw]
Subject: Re: [PATCH] staging: fbtft: fix a typo

On Fri, 26 Mar 2021 10:33:57 +0100
Greg KH <[email protected]> wrote:

> On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote:
> > On Fri, 26 Mar 2021 09:37:48 +0100
> > Greg KH <[email protected]> wrote:
> >
> > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote:
> > > > From: "Carlis" <[email protected]>
> > > >
> > > > Change 'tft' to 'TFT'
> > >
> > > Why? What is wrong with "tft"?
> > >
> > I think abbreviations should be capitalized.
>
> Why? What requires this?
Many people use capital letters for abbreviations in comments, which I
think is a good practice
>
> thanks,
>
> greg k-h

thanks,
Xuezhi Zhang