2021-03-29 09:25:37

by Liu Shixin

Subject: [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Shixin Liu <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 3be0dbc674bd..39e3280030d6 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -97,7 +97,7 @@ static int instance;

static struct list_head online_list;
static struct list_head removing_list;
-static spinlock_t dev_lock;
+static DEFINE_SPINLOCK(dev_lock);

/*
* Global variable used to hold the major block device number
@@ -4363,8 +4363,6 @@ static int __init mtip_init(void)

pr_info(MTIP_DRV_NAME " Version " MTIP_DRV_VERSION "\n");

- spin_lock_init(&dev_lock);
-
INIT_LIST_HEAD(&online_list);
INIT_LIST_HEAD(&removing_list);

--
2.25.1

2021-03-29 09:26:34

by Liu Shixin

Subject: [PATCH -next 2/2] mtip32xx: use LIST_HEAD() for list_head

There's no need to declare a list and then init it manually,
just use the LIST_HEAD() macro.

Signed-off-by: Shixin Liu <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 39e3280030d6..07c8b99b88c1 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -95,8 +95,8 @@
/* Device instance number, incremented each time a device is probed. */
static int instance;

-static struct list_head online_list;
-static struct list_head removing_list;
+static LIST_HEAD(online_list);
+static LIST_HEAD(removing_list);
static DEFINE_SPINLOCK(dev_lock);

/*
@@ -4363,9 +4363,6 @@ static int __init mtip_init(void)

pr_info(MTIP_DRV_NAME " Version " MTIP_DRV_VERSION "\n");

- INIT_LIST_HEAD(&online_list);
- INIT_LIST_HEAD(&removing_list);
-
/* Allocate a major block device number to use with this driver. */
error = register_blkdev(0, MTIP_DRV_NAME);
if (error <= 0) {
--
2.25.1

2021-03-29 13:40:58

by Jens Axboe

Subject: Re: [PATCH -next 1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock

On 3/29/21 3:53 AM, Shixin Liu wrote:
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().

Applied both, thanks.

--
Jens Axboe