2021-03-29 16:22:30

by Srinivas Neeli

Subject: [PATCH V2 3/5] watchdog: of_xilinx_wdt: Used dev_dbg()

From: Srinivas Goud <[email protected]>

This patch removes pr_info in stop function and adds dev_dbg()
in start/stop function to display device specific debug info.

Signed-off-by: Srinivas Goud <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
Signed-off-by: Srinivas Neeli <[email protected]>
---
Changes in V2:
-Updated minor review comments.
---
drivers/watchdog/of_xilinx_wdt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
index f76ec56859a4..5f31fdea517a 100644
--- a/drivers/watchdog/of_xilinx_wdt.c
+++ b/drivers/watchdog/of_xilinx_wdt.c
@@ -71,6 +71,8 @@ static int xilinx_wdt_start(struct watchdog_device *wdd)

spin_unlock(&xdev->spinlock);

+ dev_dbg(wdd->parent, "Watchdog Started!\n");
+
return 0;
}

@@ -92,7 +94,7 @@ static int xilinx_wdt_stop(struct watchdog_device *wdd)

clk_disable(xdev->clk);

- pr_info("Stopped!\n");
+ dev_dbg(wdd->parent, "Watchdog Stopped!\n");

return 0;
}
--
2.9.1

2021-03-29 21:58:43

by Guenter Roeck

Subject: Re: [PATCH V2 3/5] watchdog: of_xilinx_wdt: Used dev_dbg()

On Mon, Mar 29, 2021 at 09:49:37PM +0530, Srinivas Neeli wrote:
> From: Srinivas Goud <[email protected]>
>
> This patch removes pr_info in stop function and adds dev_dbg()
> in start/stop function to display device specific debug info.
>
> Signed-off-by: Srinivas Goud <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> Signed-off-by: Srinivas Neeli <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> Changes in V2:
> -Updated minor review comments.
> ---
> drivers/watchdog/of_xilinx_wdt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c
> index f76ec56859a4..5f31fdea517a 100644
> --- a/drivers/watchdog/of_xilinx_wdt.c
> +++ b/drivers/watchdog/of_xilinx_wdt.c
> @@ -71,6 +71,8 @@ static int xilinx_wdt_start(struct watchdog_device *wdd)
>
> spin_unlock(&xdev->spinlock);
>
> + dev_dbg(wdd->parent, "Watchdog Started!\n");
> +
> return 0;
> }
>
> @@ -92,7 +94,7 @@ static int xilinx_wdt_stop(struct watchdog_device *wdd)
>
> clk_disable(xdev->clk);
>
> - pr_info("Stopped!\n");
> + dev_dbg(wdd->parent, "Watchdog Stopped!\n");
>
> return 0;
> }
> --
> 2.9.1
>