2021-03-31 10:03:28

by Geert Uytterhoeven

Subject: [PATCH] media: VIDEO_IMX8_JPEG should depend on ARCH_MXC and not default to m

The i.MX8 QXP/QM integrated JPEG encoder/decoder is only present on
Freescale/NXP i.MX8 QXP and QM SoCs. Hence add a dependency on
ARCH_MXC, to prevent asking the user about this driver when configuring
a kernel without i.MX8 support.

Drop the "default m" (which means "default y" if CONFIG_MODULES is not
enabled), as merely enabling CONFIG_COMPILE_TEST should not enable
additional code.

Fixes: 2db16c6ed72ce644 ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/media/platform/imx-jpeg/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/imx-jpeg/Kconfig b/drivers/media/platform/imx-jpeg/Kconfig
index d875f7c88cdad125..0e3269d06ded30ec 100644
--- a/drivers/media/platform/imx-jpeg/Kconfig
+++ b/drivers/media/platform/imx-jpeg/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
config VIDEO_IMX8_JPEG
tristate "IMX8 JPEG Encoder/Decoder"
+ depends on ARCH_MXC || COMPILE_TEST
depends on VIDEO_DEV && VIDEO_V4L2
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
--
2.25.1

2021-04-06 18:29:24

by Hans Verkuil

Subject: Re: [PATCH] media: VIDEO_IMX8_JPEG should depend on ARCH_MXC and not default to m

Hi Geert,

On 31/03/2021 10:17, Geert Uytterhoeven wrote:
> The i.MX8 QXP/QM integrated JPEG encoder/decoder is only present on
> Freescale/NXP i.MX8 QXP and QM SoCs. Hence add a dependency on
> ARCH_MXC, to prevent asking the user about this driver when configuring
> a kernel without i.MX8 support.
>
> Drop the "default m" (which means "default y" if CONFIG_MODULES is not
> enabled), as merely enabling CONFIG_COMPILE_TEST should not enable
> additional code.

You do not actually drop 'default m' in the patch. Either the patch or the
commit message is wrong.

Regards,

Hans

>
> Fixes: 2db16c6ed72ce644 ("media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/media/platform/imx-jpeg/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/imx-jpeg/Kconfig b/drivers/media/platform/imx-jpeg/Kconfig
> index d875f7c88cdad125..0e3269d06ded30ec 100644
> --- a/drivers/media/platform/imx-jpeg/Kconfig
> +++ b/drivers/media/platform/imx-jpeg/Kconfig
> @@ -1,6 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> config VIDEO_IMX8_JPEG
> tristate "IMX8 JPEG Encoder/Decoder"
> + depends on ARCH_MXC || COMPILE_TEST
> depends on VIDEO_DEV && VIDEO_V4L2
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
>

2021-04-06 18:32:58

by Geert Uytterhoeven

Subject: Re: [PATCH] media: VIDEO_IMX8_JPEG should depend on ARCH_MXC and not default to m

Hoi Hans,

On Tue, Apr 6, 2021 at 11:24 AM Hans Verkuil <[email protected]> wrote:
> On 31/03/2021 10:17, Geert Uytterhoeven wrote:
> > The i.MX8 QXP/QM integrated JPEG encoder/decoder is only present on
> > Freescale/NXP i.MX8 QXP and QM SoCs. Hence add a dependency on
> > ARCH_MXC, to prevent asking the user about this driver when configuring
> > a kernel without i.MX8 support.
> >
> > Drop the "default m" (which means "default y" if CONFIG_MODULES is not
> > enabled), as merely enabling CONFIG_COMPILE_TEST should not enable
> > additional code.
>
> You do not actually drop 'default m' in the patch. Either the patch or the
> commit message is wrong.

Oops, the patch is wrong.
V2 sent.
Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds