2021-04-01 08:22:48

by Jiabing Wan

Subject: [PATCH] drm/drm_internal.h: Remove repeated struct declaration

struct drm_gem_object is declared twice. One is declared
at 40th line. The blew one is not needed. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/gpu/drm/drm_internal.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
index fad2249ee67b..1265de2b9d90 100644
--- a/drivers/gpu/drm/drm_internal.h
+++ b/drivers/gpu/drm/drm_internal.h
@@ -170,7 +170,6 @@ void drm_sysfs_connector_remove(struct drm_connector *connector);
void drm_sysfs_lease_event(struct drm_device *dev);

/* drm_gem.c */
-struct drm_gem_object;
int drm_gem_init(struct drm_device *dev);
int drm_gem_handle_create_tail(struct drm_file *file_priv,
struct drm_gem_object *obj,
--
2.25.1

2021-04-08 11:07:04

by Daniel Vetter

Subject: Re: [PATCH] drm/drm_internal.h: Remove repeated struct declaration

On Thu, Apr 01, 2021 at 04:17:03PM +0800, Wan Jiabing wrote:
> struct drm_gem_object is declared twice. One is declared
> at 40th line. The blew one is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>

Pushed to drm-misc-next, thanks for your patch.
-Daniel

> ---
> drivers/gpu/drm/drm_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h
> index fad2249ee67b..1265de2b9d90 100644
> --- a/drivers/gpu/drm/drm_internal.h
> +++ b/drivers/gpu/drm/drm_internal.h
> @@ -170,7 +170,6 @@ void drm_sysfs_connector_remove(struct drm_connector *connector);
> void drm_sysfs_lease_event(struct drm_device *dev);
>
> /* drm_gem.c */
> -struct drm_gem_object;
> int drm_gem_init(struct drm_device *dev);
> int drm_gem_handle_create_tail(struct drm_file *file_priv,
> struct drm_gem_object *obj,
> --
> 2.25.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch