2021-04-01 18:13:50

by Qiheng Lin

Subject: [PATCH -next] mm/vmalloc: Fix non-conforming function headers

Fix the following W=1 kernel build warning(s):
mm/vmalloc.c:425: warning: expecting prototype for vunmap_range_noflush(). Prototype was for vunmap_range() instead

Signed-off-by: Qiheng Lin <[email protected]>
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 8b564f91a610..4238e407eb2d 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -413,7 +413,7 @@ void vunmap_range_noflush(unsigned long start, unsigned long end)
}

/**
- * vunmap_range_noflush - unmap kernel virtual addresses
+ * vunmap_range - unmap kernel virtual addresses
* @addr: start of the VM area to unmap
* @end: end of the VM area to unmap (non-inclusive)
*
--
2.25.1

2021-04-02 00:22:48

by Andrew Morton

Subject: Re: [PATCH -next] mm/vmalloc: Fix non-conforming function headers

On Thu, 1 Apr 2021 21:22:48 +0800 Qiheng Lin <[email protected]> wrote:

> Fix the following W=1 kernel build warning(s):
> mm/vmalloc.c:425: warning: expecting prototype for vunmap_range_noflush(). Prototype was for vunmap_range() instead
>
> ...
>
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -413,7 +413,7 @@ void vunmap_range_noflush(unsigned long start, unsigned long end)
> }
>
> /**
> - * vunmap_range_noflush - unmap kernel virtual addresses
> + * vunmap_range - unmap kernel virtual addresses
> * @addr: start of the VM area to unmap
> * @end: end of the VM area to unmap (non-inclusive)
> *

Thanks. Nick has just sent along a patch which fixed this.