2021-04-03 11:50:52

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH net-next v1 6/9] net: dsa: qca: ar9331: add ageing time support

This switch provides global ageing time configuration, so let DSA use
it.

Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/net/dsa/qca/ar9331.c | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)

diff --git a/drivers/net/dsa/qca/ar9331.c b/drivers/net/dsa/qca/ar9331.c
index 4a98f14f31f4..b2c22ba924f0 100644
--- a/drivers/net/dsa/qca/ar9331.c
+++ b/drivers/net/dsa/qca/ar9331.c
@@ -1115,6 +1115,25 @@ static void ar9331_sw_port_fast_age(struct dsa_switch *ds, int port)
dev_err_ratelimited(priv->dev, "%s: error: %i\n", __func__, ret);
}

+static int ar9331_sw_set_ageing_time(struct dsa_switch *ds,
+ unsigned int ageing_time)
+{
+ struct ar9331_sw_priv *priv = (struct ar9331_sw_priv *)ds->priv;
+ struct regmap *regmap = priv->regmap;
+ u32 time, val;
+
+ time = DIV_ROUND_UP(ageing_time, AR9331_SW_AT_AGE_TIME_COEF);
+ if (!time)
+ time = 1;
+ else if (time > U16_MAX)
+ time = U16_MAX;
+
+ val = FIELD_PREP(AR9331_SW_AT_AGE_TIME, time) | AR9331_SW_AT_AGE_EN;
+ return regmap_update_bits(regmap, AR9331_SW_REG_ADDR_TABLE_CTRL,
+ AR9331_SW_AT_AGE_EN | AR9331_SW_AT_AGE_TIME,
+ val);
+}
+
static const struct dsa_switch_ops ar9331_sw_ops = {
.get_tag_protocol = ar9331_sw_get_tag_protocol,
.setup = ar9331_sw_setup,
@@ -1130,6 +1149,7 @@ static const struct dsa_switch_ops ar9331_sw_ops = {
.port_fdb_dump = ar9331_sw_port_fdb_dump,
.port_mdb_add = ar9331_sw_port_mdb_add,
.port_mdb_del = ar9331_sw_port_mdb_del,
+ .set_ageing_time = ar9331_sw_set_ageing_time,
};

static irqreturn_t ar9331_sw_irq(int irq, void *data)
@@ -1476,6 +1496,8 @@ static int ar9331_sw_probe(struct mdio_device *mdiodev)
priv->ops = ar9331_sw_ops;
ds->ops = &priv->ops;
dev_set_drvdata(&mdiodev->dev, priv);
+ ds->ageing_time_min = AR9331_SW_AT_AGE_TIME_COEF;
+ ds->ageing_time_max = AR9331_SW_AT_AGE_TIME_COEF * U16_MAX;

for (i = 0; i < ARRAY_SIZE(priv->port); i++) {
struct ar9331_sw_port *port = &priv->port[i];
--
2.29.2


2021-04-03 15:28:04

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH net-next v1 6/9] net: dsa: qca: ar9331: add ageing time support

On Sat, Apr 03, 2021 at 01:48:45PM +0200, Oleksij Rempel wrote:
> This switch provides global ageing time configuration, so let DSA use
> it.
>
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2021-04-04 02:23:55

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH net-next v1 6/9] net: dsa: qca: ar9331: add ageing time support



On 4/3/2021 04:48, Oleksij Rempel wrote:
> This switch provides global ageing time configuration, so let DSA use
> it.
>
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian