2021-02-10 03:03:44

by Jiapeng Chong

[permalink] [raw]

Subject: [PATCH] power: supply: Use true and false for bool variable

---

Fix the following coccicheck warning:

./include/linux/power_supply.h:507:9-10: WARNING: return of 0/1 in
function 'power_supply_is_watt_property' with return type bool.

./include/linux/power_supply.h:479:9-10: WARNING: return of 0/1 in
function 'power_supply_is_amp_property' with return type bool.

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
include/linux/power_supply.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 81a55e9..029e6e9 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -476,12 +476,12 @@ static inline bool power_supply_is_amp_property(enum power_supply_property psp)
case POWER_SUPPLY_PROP_CURRENT_NOW:
case POWER_SUPPLY_PROP_CURRENT_AVG:
case POWER_SUPPLY_PROP_CURRENT_BOOT:
- return 1;
+ return true;
default:
break;
}

- return 0;
+ return false;
}

static inline bool power_supply_is_watt_property(enum power_supply_property psp)
@@ -504,12 +504,12 @@ static inline bool power_supply_is_watt_property(enum power_supply_property psp)
case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
case POWER_SUPPLY_PROP_POWER_NOW:
- return 1;
+ return true;
default:
break;
}

- return 0;
+ return false;
}

#ifdef CONFIG_POWER_SUPPLY_HWMON
--
1.8.3.1

2021-04-05 18:00:58

by Sebastian Reichel

[permalink] [raw]

Subject: Re: [PATCH] power: supply: Use true and false for bool variable

---

Hi,

On Tue, Feb 09, 2021 at 05:58:43PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./include/linux/power_supply.h:507:9-10: WARNING: return of 0/1 in
> function 'power_supply_is_watt_property' with return type bool.
>
> ./include/linux/power_supply.h:479:9-10: WARNING: return of 0/1 in
> function 'power_supply_is_amp_property' with return type bool.
>
> Reported-by: Abaci Robot<[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> include/linux/power_supply.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index 81a55e9..029e6e9 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -476,12 +476,12 @@ static inline bool power_supply_is_amp_property(enum power_supply_property psp)
> case POWER_SUPPLY_PROP_CURRENT_NOW:
> case POWER_SUPPLY_PROP_CURRENT_AVG:
> case POWER_SUPPLY_PROP_CURRENT_BOOT:
> - return 1;
> + return true;
> default:
> break;
> }
>
> - return 0;
> + return false;
> }
>
> static inline bool power_supply_is_watt_property(enum power_supply_property psp)
> @@ -504,12 +504,12 @@ static inline bool power_supply_is_watt_property(enum power_supply_property psp)
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
> case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX:
> case POWER_SUPPLY_PROP_POWER_NOW:
> - return 1;
> + return true;
> default:
> break;
> }
>
> - return 0;
> + return false;
> }
>
> #ifdef CONFIG_POWER_SUPPLY_HWMON
> --
> 1.8.3.1
>

---

Attachments:

(No filename) (1.67 kB)
signature.asc (849.00 B)
Download all attachments