2021-04-05 22:58:08

by Rui Salvaterra

Subject: [PATCH] ubifs: default to zstd compression

Compared to lzo and zlib, zstd is the best all-around performer, both in terms
of speed and compression ratio. Set it as the default, if available.

Signed-off-by: Rui Salvaterra <[email protected]>
---
fs/ubifs/sb.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c
index c160f718c288..e7693b94e5b5 100644
--- a/fs/ubifs/sb.c
+++ b/fs/ubifs/sb.c
@@ -53,6 +53,9 @@

static int get_default_compressor(struct ubifs_info *c)
{
+ if (ubifs_compr_present(c, UBIFS_COMPR_ZSTD))
+ return UBIFS_COMPR_ZSTD;
+
if (ubifs_compr_present(c, UBIFS_COMPR_LZO))
return UBIFS_COMPR_LZO;

--
2.31.1

2021-04-08 11:00:58

by Richard Weinberger

Subject: Re: [PATCH] ubifs: default to zstd compression

On Mon, Apr 5, 2021 at 5:36 PM Rui Salvaterra <[email protected]> wrote:
>
> Compared to lzo and zlib, zstd is the best all-around performer, both in terms
> of speed and compression ratio. Set it as the default, if available.

I was about to NACK this patch but by looking at the diff I realized
that you change
the default compressor only for the default filesystem as created by
UBIFS itself.
Queued for the merge window. :-)

--
Thanks,
//richard

2021-04-08 14:24:34

by Rui Salvaterra

Subject: Re: [PATCH] ubifs: default to zstd compression

Hi, Richard,

On Thu, 8 Apr 2021 at 12:00, Richard Weinberger
<[email protected]> wrote:
>
> I was about to NACK this patch but by looking at the diff I realized
> that you change
> the default compressor only for the default filesystem as created by
> UBIFS itself.

Yes, that was the idea. :)

> Queued for the merge window. :-)

Thanks a lot!

Rui