2021-04-06 06:20:48

by Salil Mehta

Subject: [PATCH V2 net 0/2] Misc. fixes for hns3 driver

Fixes for the miscellaneous problems found during the review of the code.

Change Summary:
Patch 1/2, Change V1->V2:
[1] Fixed comments from Leon Romanovsky
Link: https://lkml.org/lkml/2021/4/4/14
Patch 2/2, Change V1->V2:
None

Salil Mehta (2):
net: hns3: Remove the left over redundant check & assignment
net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

--
2.17.1

2021-04-06 06:20:49

by Salil Mehta

Subject: [PATCH V2 net 2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

Code to defer the reset(which caps the frequency of the reset) schedules the
timer and returns. Hence, following 'else-if' looks un-necessary.

Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently")
Signed-off-by: Salil Mehta <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index 58d210bbb311..2dd2af269b46 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -3980,7 +3980,9 @@ static void hclge_reset_event(struct pci_dev *pdev, struct hnae3_handle *handle)
HCLGE_RESET_INTERVAL))) {
mod_timer(&hdev->reset_timer, jiffies + HCLGE_RESET_INTERVAL);
return;
- } else if (hdev->default_reset_request) {
+ }
+
+ if (hdev->default_reset_request) {
hdev->reset_level =
hclge_get_reset_level(ae_dev,
&hdev->default_reset_request);
--
2.17.1

2021-04-06 10:29:59

by patchwork-bot+netdevbpf

Subject: Re: [PATCH V2 net 0/2] Misc. fixes for hns3 driver

Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Mon, 5 Apr 2021 18:06:43 +0100 you wrote:
> Fixes for the miscellaneous problems found during the review of the code.
>
> Change Summary:
> Patch 1/2, Change V1->V2:
> [1] Fixed comments from Leon Romanovsky
> Link: https://lkml.org/lkml/2021/4/4/14
> Patch 2/2, Change V1->V2:
> None
>
> [...]

Here is the summary with links:
- [V2,net,1/2] net: hns3: Remove the left over redundant check & assignment
https://git.kernel.org/netdev/net/c/9a6aaf61487e
- [V2,net,2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()
https://git.kernel.org/netdev/net/c/0600771fa6b2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html