2021-04-06 07:08:17

by Salil Mehta

[permalink] [raw]
Subject: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

Limiting the scope of the variable vector_ring_chain to the block where it
is used.

Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC")
Signed-off-by: Salil Mehta <[email protected]>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index bf4302a5cf95..65752f363f43 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -3704,7 +3704,6 @@ static void hns3_nic_set_cpumask(struct hns3_nic_priv *priv)

static int hns3_nic_init_vector_data(struct hns3_nic_priv *priv)
{
- struct hnae3_ring_chain_node vector_ring_chain;
struct hnae3_handle *h = priv->ae_handle;
struct hns3_enet_tqp_vector *tqp_vector;
int ret;
@@ -3736,6 +3735,8 @@ static int hns3_nic_init_vector_data(struct hns3_nic_priv *priv)
}

for (i = 0; i < priv->vector_num; i++) {
+ struct hnae3_ring_chain_node vector_ring_chain;
+
tqp_vector = &priv->tqp_vector[i];

tqp_vector->rx_group.total_bytes = 0;
--
2.17.1


2021-04-06 10:30:28

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon, 5 Apr 2021 18:28:25 +0100 you wrote:
> Limiting the scope of the variable vector_ring_chain to the block where it
> is used.
>
> Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC")
> Signed-off-by: Salil Mehta <[email protected]>
> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
- [net] net: hns3: Limiting the scope of vector_ring_chain variable
https://git.kernel.org/netdev/net-next/c/d392ecd1bc29

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


2021-04-06 17:11:06

by Salil Mehta

[permalink] [raw]
Subject: RE: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

Hi Dave,
Hope I am not missing something and not sure how this patchwork bot works,
the patch was sent for -net repo (i.e. bug fixes branch) but it got applied
to the -net-next repo.

> Subject: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of
> vector_ring_chain variable

[...]

> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):
>

I was wondering if I missed anything in my submission or because of some
other reason this patch was chosen to be applied to the -net-next repo
instead. Perhaps this is not classified as bug?

Many thanks
Salil

> From: [email protected]
> [mailto:[email protected]]
> Sent: Monday, April 5, 2021 11:10 PM
> To: Salil Mehta <[email protected]>
> Cc: [email protected]; [email protected]; [email protected];
> [email protected]; Linuxarm <[email protected]>;
> [email protected]
> Subject: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of
> vector_ring_chain variable
>
> Hello:
>
> This patch was applied to netdev/net-next.git (refs/heads/master):
>
> On Mon, 5 Apr 2021 18:28:25 +0100 you wrote:
> > Limiting the scope of the variable vector_ring_chain to the block where it
> > is used.
> >
> > Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08
> SoC")
> > Signed-off-by: Salil Mehta <[email protected]>
> > ---
> > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Here is the summary with links:
> - [net] net: hns3: Limiting the scope of vector_ring_chain variable
> https://git.kernel.org/netdev/net-next/c/d392ecd1bc29
>
> You are awesome, thank you!
> --
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
>
> _______________________________________________
> Linuxarm mailing list -- [email protected]
> To unsubscribe send an email to [email protected]