2021-04-06 23:50:57

by Jiabing Wan

Subject: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration

struct mem_info is defined at 22nd line.
The declaration here is unnecessary. Remove it.

Signed-off-by: Wan Jiabing <[email protected]>
---
tools/perf/util/mem-events.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
index 755cef7e0625..5ddbeaa057b0 100644
--- a/tools/perf/util/mem-events.h
+++ b/tools/perf/util/mem-events.h
@@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);

void perf_mem_events__list(void);

-struct mem_info;
int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
--
2.25.1

2021-04-07 09:58:19

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration

Em Tue, Apr 06, 2021 at 06:51:02PM +0800, Wan Jiabing escreveu:
> struct mem_info is defined at 22nd line.
> The declaration here is unnecessary. Remove it.


Thanks, applied.

- Arnaldo

> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> tools/perf/util/mem-events.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/perf/util/mem-events.h b/tools/perf/util/mem-events.h
> index 755cef7e0625..5ddbeaa057b0 100644
> --- a/tools/perf/util/mem-events.h
> +++ b/tools/perf/util/mem-events.h
> @@ -44,7 +44,6 @@ bool is_mem_loads_aux_event(struct evsel *leader);
>
> void perf_mem_events__list(void);
>
> -struct mem_info;
> int perf_mem__tlb_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> int perf_mem__snp_scnprintf(char *out, size_t sz, struct mem_info *mem_info);
> --
> 2.25.1
>

--

- Arnaldo