2021-04-07 21:00:55

by Yu Kuai

Subject: [PATCH] macintosh/via-pmu: Make some symbols static

The sparse tool complains as follows:

drivers/macintosh/via-pmu.c:183:5: warning:
symbol 'pmu_cur_battery' was not declared. Should it be static?
drivers/macintosh/via-pmu.c:190:5: warning:
symbol '__fake_sleep' was not declared. Should it be static?

These symbols are not used outside of via-pmu.c, so this
commit marks them static.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yu Kuai <[email protected]>
---
drivers/macintosh/via-pmu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 73e6ae88fafd..478766434919 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -180,14 +180,14 @@ static struct proc_dir_entry *proc_pmu_options;
static int option_server_mode;

int pmu_battery_count;
-int pmu_cur_battery;
+static int pmu_cur_battery;
unsigned int pmu_power_flags = PMU_PWR_AC_PRESENT;
struct pmu_battery_info pmu_batteries[PMU_MAX_BATTERIES];
static int query_batt_timer = BATTERY_POLLING_COUNT;
static struct adb_request batt_req;
static struct proc_dir_entry *proc_pmu_batt[PMU_MAX_BATTERIES];

-int __fake_sleep;
+static int __fake_sleep;
int asleep;

#ifdef CONFIG_ADB
--
2.25.4

2021-04-19 04:09:06

by Michael Ellerman

Subject: Re: [PATCH] macintosh/via-pmu: Make some symbols static

On Wed, 7 Apr 2021 20:58:03 +0800, Yu Kuai wrote:
> The sparse tool complains as follows:
>
> drivers/macintosh/via-pmu.c:183:5: warning:
> symbol 'pmu_cur_battery' was not declared. Should it be static?
> drivers/macintosh/via-pmu.c:190:5: warning:
> symbol '__fake_sleep' was not declared. Should it be static?
>
> [...]

Applied to powerpc/next.

[1/1] macintosh/via-pmu: Make some symbols static
https://git.kernel.org/powerpc/c/95d143923379ffb0e706b064305681d44c05ec4b

cheers