2021-04-09 02:01:22

by chenlifu

[permalink] [raw]
Subject: [PATCH -next] ASoC: sti: sti_uniperif: add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Chen Lifu <[email protected]>
---
sound/soc/sti/sti_uniperif.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
index 67315d9b352d..e3561f00ed40 100644
--- a/sound/soc/sti/sti_uniperif.c
+++ b/sound/soc/sti/sti_uniperif.c
@@ -97,6 +97,7 @@ static const struct of_device_id snd_soc_sti_match[] = {
},
{},
};
+MODULE_DEVICE_TABLE(of, snd_soc_sti_match);

int sti_uniperiph_reset(struct uniperif *uni)
{


2021-04-09 07:45:49

by Arnaud POULIQUEN

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: sti: sti_uniperif: add missing MODULE_DEVICE_TABLE



On 4/9/21 3:59 AM, Chen Lifu wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Chen Lifu <[email protected]>

Reviewed-by: Arnaud Pouliquen <[email protected]>

Thanks,
Arnaud

> ---
> sound/soc/sti/sti_uniperif.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
> index 67315d9b352d..e3561f00ed40 100644
> --- a/sound/soc/sti/sti_uniperif.c
> +++ b/sound/soc/sti/sti_uniperif.c
> @@ -97,6 +97,7 @@ static const struct of_device_id snd_soc_sti_match[] = {
> },
> {},
> };
> +MODULE_DEVICE_TABLE(of, snd_soc_sti_match);
>
> int sti_uniperiph_reset(struct uniperif *uni)
> {
>

2021-04-13 19:21:33

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH -next] ASoC: sti: sti_uniperif: add missing MODULE_DEVICE_TABLE

On Fri, 9 Apr 2021 09:59:53 +0800, Chen Lifu wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sti: sti_uniperif: add missing MODULE_DEVICE_TABLE
commit: 462c47c2fcc26d838c82646a31d6e3e8fc01ce68

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark