2021-04-09 23:44:17

by angkery

Subject: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

From: Junlin Yang <[email protected]>

The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irq', so making 'irq' an int, and change the position to
keep the code format.

Fixes coccicheck warnings:
./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
WARNING: Unsigned expression compared with zero: irq > 0

Signed-off-by: Junlin Yang <[email protected]>
---
changes in v1:
update the commit information.

drivers/ata/pata_ixp4xx_cf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index abc0e87..43215a4 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,

static int ixp4xx_pata_probe(struct platform_device *pdev)
{
- unsigned int irq;
struct resource *cs0, *cs1;
struct ata_host *host;
struct ata_port *ap;
struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev);
int ret;
+ int irq;

cs0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
cs1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
--
1.9.1

2021-04-10 08:52:56

by Sergei Shtylyov

Subject: Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

On 10.04.2021 2:42, angkery wrote:

> From: Junlin Yang <[email protected]>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> Fixes coccicheck warnings:
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0
>
> Signed-off-by: Junlin Yang <[email protected]>
> ---
> changes in v1:
> update the commit information.

Not seeing what's updated, and anwyways it should read irq < 0, else it
doesn't make sense...

[...]

MBR, Sergei