2021-04-13 00:06:34

by Pavel Skripkin

[permalink] [raw]
Subject: [PATCH] net: mac802154: fix WARNING in ieee802154_del_device

syzbot reported WARNING in ieee802154_del_device. The problem
was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR
mutex won't be initialized, but ieee802154_del_device() accessing it.

Reported-by: [email protected]
Signed-off-by: Pavel Skripkin <[email protected]>
---
net/mac802154/iface.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/mac802154/iface.c b/net/mac802154/iface.c
index 1cf5ac09edcb..be8d2a02c882 100644
--- a/net/mac802154/iface.c
+++ b/net/mac802154/iface.c
@@ -599,6 +599,7 @@ ieee802154_setup_sdata(struct ieee802154_sub_if_data *sdata,

break;
case NL802154_IFTYPE_MONITOR:
+ mutex_init(&sdata->sec_mtx);
sdata->dev->needs_free_netdev = true;
sdata->dev->netdev_ops = &mac802154_monitor_ops;
wpan_dev->promiscuous_mode = true;
--
2.31.1