2021-04-14 19:05:19

by Pi-Hsun Shih

Subject: [PATCH] platform/chrome: cros_usbpd_notify: Listen to EC_HOST_EVENT_USB_MUX host event

On system that use ACPI, cros_usbpd_notify gets notifications of USB MUX
host event same as PD host events [1]. But currently on system that use
DT, the driver only listen on EC_HOST_EVENT_PD_MCU.

Add EC_HOST_EVENT_USB_MUX to the list of host events, so we have same
behavior on all platforms.

[1]: https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/refs/heads/chromeos-2016.05/src/ec/google/chromeec/acpi/ec.asl#382

Signed-off-by: Pi-Hsun Shih <[email protected]>
---
drivers/platform/chrome/cros_usbpd_notify.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/cros_usbpd_notify.c b/drivers/platform/chrome/cros_usbpd_notify.c
index 7f36142ab12a..48a6617aa12f 100644
--- a/drivers/platform/chrome/cros_usbpd_notify.c
+++ b/drivers/platform/chrome/cros_usbpd_notify.c
@@ -220,7 +220,8 @@ static int cros_usbpd_notify_plat(struct notifier_block *nb,
if (!host_event)
return NOTIFY_DONE;

- if (host_event & EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU)) {
+ if (host_event & (EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |
+ EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_MUX))) {
cros_usbpd_get_event_and_notify(pdnotify->dev, ec_dev);
return NOTIFY_OK;
}

base-commit: 50987beca096a7ed4f453a6da245fd6a2fadedeb
--
2.31.1.295.g9ea45b61b8-goog

2021-04-23 06:58:30

by Enric Balletbo i Serra

Subject: Re: [PATCH] platform/chrome: cros_usbpd_notify: Listen to EC_HOST_EVENT_USB_MUX host event

On Wed, 14 Apr 2021 14:45:24 +0800, Pi-Hsun Shih wrote:
> On system that use ACPI, cros_usbpd_notify gets notifications of USB MUX
> host event same as PD host events [1]. But currently on system that use
> DT, the driver only listen on EC_HOST_EVENT_PD_MCU.
>
> Add EC_HOST_EVENT_USB_MUX to the list of host events, so we have same
> behavior on all platforms.
>
> [...]

Applied, thanks!

[1/1] platform/chrome: cros_usbpd_notify: Listen to EC_HOST_EVENT_USB_MUX host event
commit: 4423ee65f76818c8a8994e6f5821372661ea7f89

Best regards,
--
Enric Balletbo i Serra <[email protected]>