2021-04-15 07:42:11

by zhuguangqing83

Subject: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler

From: Guangqing Zhu <[email protected]>

Coccinelle noticed:
sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Signed-off-by: Guangqing Zhu <[email protected]>
---
sound/soc/codecs/wcd934x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
index 5fe403307b72..cddc49bbb7f6 100644
--- a/sound/soc/codecs/wcd934x.c
+++ b/sound/soc/codecs/wcd934x.c
@@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)

ret = devm_request_threaded_irq(dev, irq, NULL,
wcd934x_slim_irq_handler,
- IRQF_TRIGGER_RISING,
+ IRQF_TRIGGER_RISING | IRQF_ONESHOT,
"slim", wcd);
if (ret) {
dev_err(dev, "Failed to request slimbus irq\n");
--
2.17.1

2021-04-15 09:36:00

by Srinivas Kandagatla

Subject: Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler

On 15/04/2021 08:38, [email protected] wrote:
> From: Guangqing Zhu <[email protected]>
>
> Coccinelle noticed:
> sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT
>
> Signed-off-by: Guangqing Zhu <[email protected]>
> ---

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla <[email protected]>

> sound/soc/codecs/wcd934x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
> index 5fe403307b72..cddc49bbb7f6 100644
> --- a/sound/soc/codecs/wcd934x.c
> +++ b/sound/soc/codecs/wcd934x.c
> @@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
>
> ret = devm_request_threaded_irq(dev, irq, NULL,
> wcd934x_slim_irq_handler,
> - IRQF_TRIGGER_RISING,
> + IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> "slim", wcd);
> if (ret) {
> dev_err(dev, "Failed to request slimbus irq\n");
>

2021-04-15 18:35:11

by Mark Brown

Subject: Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler

On Thu, 15 Apr 2021 15:38:29 +0800, [email protected] wrote:
> Coccinelle noticed:
> sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler
commit: 22ff9c4230bd09ade8971c05463b90ec1d513245

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark