2021-04-15 14:45:42

by Joerg Roedel

Subject: [PATCH] iommu/fsl-pamu: Fix uninitialized variable warning

From: Joerg Roedel <[email protected]>

The variable 'i' in the function update_liodn_stash() is not
initialized and only used in a debug printk(). So it has no
meaning at all, remove it.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Joerg Roedel <[email protected]>
---
drivers/iommu/fsl_pamu_domain.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/fsl_pamu_domain.c b/drivers/iommu/fsl_pamu_domain.c
index 32944d67baa4..0ac781186dbd 100644
--- a/drivers/iommu/fsl_pamu_domain.c
+++ b/drivers/iommu/fsl_pamu_domain.c
@@ -57,14 +57,13 @@ static int __init iommu_init_mempool(void)
static int update_liodn_stash(int liodn, struct fsl_dma_domain *dma_domain,
u32 val)
{
- int ret = 0, i;
+ int ret = 0;
unsigned long flags;

spin_lock_irqsave(&iommu_lock, flags);
ret = pamu_update_paace_stash(liodn, val);
if (ret) {
- pr_debug("Failed to update SPAACE %d field for liodn %d\n ",
- i, liodn);
+ pr_debug("Failed to update SPAACE for liodn %d\n ", liodn);
spin_unlock_irqrestore(&iommu_lock, flags);
return ret;
}
--
2.30.2

2021-04-15 15:09:54

by Christoph Hellwig

Subject: Re: [PATCH] iommu/fsl-pamu: Fix uninitialized variable warning

On Thu, Apr 15, 2021 at 04:44:42PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <[email protected]>
>
> The variable 'i' in the function update_liodn_stash() is not
> initialized and only used in a debug printk(). So it has no
> meaning at all, remove it.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Joerg Roedel <[email protected]>

Sorry for introducing this. The fix looks good:

Reviewed-by: Christoph Hellwig <[email protected]>