2021-04-16 13:17:47

by Mike Galbraith

[permalink] [raw]
Subject: Re: [patch] x86/crash: fix crash_setup_memmap_entries() out-of-bounds access

On Fri, 2021-04-16 at 14:16 +0200, Borislav Petkov wrote:
>
> Please be more verbose and structure your commit message like this:

Hrmph, I thought it was too verbose for dinky one-liner if anything. I
showed the complaint along with an 8x10 color glossy crime scene photo,
then explained why it happened and what to do about it with a perhaps
terse but perfectly clear sentence.

-Mike


2021-04-16 17:28:25

by Borislav Petkov

[permalink] [raw]
Subject: Re: [patch] x86/crash: fix crash_setup_memmap_entries() out-of-bounds access

On Fri, Apr 16, 2021 at 03:16:07PM +0200, Mike Galbraith wrote:
> On Fri, 2021-04-16 at 14:16 +0200, Borislav Petkov wrote:
> >
> > Please be more verbose and structure your commit message like this:
>
> Hrmph, I thought it was too verbose for dinky one-liner if anything.

Please look at how other commit messages in tip have free text - not
only tools output.

Also, this looks like a fix for some previous commit. Please dig out
which commit introduced the issue and put its commit ID in a Fixes: tag
above your S-o-B.

If you don't have time or desire to do that, you can say so and I'll do
it myself when I get a chance.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette