2021-04-16 14:43:22

by Krzysztof Kozlowski

Subject: Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header

On 16/04/2021 16:37, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead
>
> Cc: Inki Dae <[email protected]>
> Cc: Joonyoung Shim <[email protected]>
> Cc: Seung-Woo Kim <[email protected]>
> Cc: Kyungmin Park <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Lee Jones <[email protected]>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Hi Lee,

I already sent a fix for this one on 5th of April:
https://lore.kernel.org/lkml/[email protected]/


Best regards,
Krzysztof

>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 49a2e0c539187..ae576122873e0 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, unsigned int win)
> }
>
> /**
> - * shadow_protect_win() - disable updating values from shadow registers at vsync
> + * fimd_shadow_protect_win() - disable updating values from shadow registers at vsync
> *
> * @ctx: local driver data
> * @win: window to protect registers for
>

2021-04-16 14:50:55

by Lee Jones

Subject: Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header

On Fri, 16 Apr 2021, Krzysztof Kozlowski wrote:

> On 16/04/2021 16:37, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead
> >
> > Cc: Inki Dae <[email protected]>
> > Cc: Joonyoung Shim <[email protected]>
> > Cc: Seung-Woo Kim <[email protected]>
> > Cc: Kyungmin Park <[email protected]>
> > Cc: David Airlie <[email protected]>
> > Cc: Daniel Vetter <[email protected]>
> > Cc: Krzysztof Kozlowski <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Lee Jones <[email protected]>
> > ---
> > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Hi Lee,
>
> I already sent a fix for this one on 5th of April:
> https://lore.kernel.org/lkml/[email protected]/

No problem. Thanks for letting me know.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog