2021-04-21 07:35:27

by Xiaochuan Mao

Subject: [PATCH] mips/bootinfo:correct some comments of fw_arg

from arch/mips/kernel/head.S we know that use a0~a3 for fw_arg0~fw_arg3
there is some code from head.S:
LONG_S a0, fw_arg0 # firmware arguments
LONG_S a1, fw_arg1
LONG_S a2, fw_arg2
LONG_S a3, fw_arg3

Signed-off-by: xiaochuan mao <[email protected]>
---
arch/mips/include/asm/bootinfo.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/include/asm/bootinfo.h b/arch/mips/include/asm/bootinfo.h
index 5be10ece3ef0..4c2e8173e6ec 100644
--- a/arch/mips/include/asm/bootinfo.h
+++ b/arch/mips/include/asm/bootinfo.h
@@ -107,7 +107,7 @@ extern void (*free_init_pages_eva)(void *begin, void *end);
extern char arcs_cmdline[COMMAND_LINE_SIZE];

/*
- * Registers a0, a1, a3 and a4 as passed to the kernel entry by firmware
+ * Registers a0, a1, a2 and a3 as passed to the kernel entry by firmware
*/
extern unsigned long fw_arg0, fw_arg1, fw_arg2, fw_arg3;

--
2.17.1

2021-04-21 14:26:18

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips/bootinfo:correct some comments of fw_arg

On Wed, Apr 21, 2021 at 02:19:17PM +0800, xiaochuan mao wrote:
> from arch/mips/kernel/head.S we know that use a0~a3 for fw_arg0~fw_arg3
> there is some code from head.S:
> LONG_S a0, fw_arg0 # firmware arguments
> LONG_S a1, fw_arg1
> LONG_S a2, fw_arg2
> LONG_S a3, fw_arg3
>
> Signed-off-by: xiaochuan mao <[email protected]>
> ---
> arch/mips/include/asm/bootinfo.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]