This reverts commit 63e36a381d92a9cded97e90d481ee22566557dd1.
Commits from @umn.edu addresses have been found to be submitted in "bad
faith" to try to test the kernel community's ability to review "known
malicious" changes. The result of these submissions can be found in a
paper published at the 42nd IEEE Symposium on Security and Privacy
entitled, "Open Source Insecurity: Stealthily Introducing
Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University
of Minnesota) and Kangjie Lu (University of Minnesota).
Because of this, all submissions from this group must be reverted from
the kernel tree and will need to be re-reviewed again to determine if
they actually are a valid fix. Until that work is complete, remove this
change to ensure that no problems are being introduced into the
codebase.
Cc: Qiushi Wu <[email protected]>
Cc: Hans Verkuil <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/media/platform/rcar-fcp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/rcar-fcp.c b/drivers/media/platform/rcar-fcp.c
index 5c03318ae07b..13a84c7e3586 100644
--- a/drivers/media/platform/rcar-fcp.c
+++ b/drivers/media/platform/rcar-fcp.c
@@ -102,10 +102,8 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
return 0;
ret = pm_runtime_get_sync(fcp->dev);
- if (ret < 0) {
- pm_runtime_put_noidle(fcp->dev);
+ if (ret < 0)
return ret;
- }
return 0;
}
--
2.31.1
Hi!
> --- a/drivers/media/platform/rcar-fcp.c
> +++ b/drivers/media/platform/rcar-fcp.c
> @@ -102,10 +102,8 @@ int rcar_fcp_enable(struct rcar_fcp_device *fcp)
> return 0;
>
> ret = pm_runtime_get_sync(fcp->dev);
> - if (ret < 0) {
> - pm_runtime_put_noidle(fcp->dev);
> + if (ret < 0)
> return ret;
> - }
>
> return 0;
> }
This one, 12/, 13/ 14/ of the series look correct to me, and should NOT be
reverted.
Additinaly 19/, 21/, 27/, 30/, 32/, 33/ and 62/ looked correct to me,
but you already decided they should be kept, so no action needs to be
done there.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek