2021-04-21 18:48:50

by Arnd Bergmann

Subject: [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused

From: Arnd Bergmann <[email protected]>

Depending on the configuration, there are no references to these
two helpers:

drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]

Mark them as __maybe_unused to shut up the warnings without adding
fragile #ifdefs.

Fixes: b8bb3d9c9b74 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/phy/tegra/xusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
index 0aadac678191..963de5913e50 100644
--- a/drivers/phy/tegra/xusb.c
+++ b/drivers/phy/tegra/xusb.c
@@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
return err;
}

-static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);

@@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
return 0;
}

-static int tegra_xusb_padctl_resume_noirq(struct device *dev)
+static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
{
struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);

--
2.29.2

2021-04-22 01:51:31

by JC Kuo

Subject: Re: [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused

Hi Arnd,
Thanks for the fix.

Reviewed-by: JC Kuo <[email protected]>

On 4/21/21 9:56 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Depending on the configuration, there are no references to these
> two helpers:
>
> drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
> 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused to shut up the warnings without adding
> fragile #ifdefs.
>
> Fixes: b8bb3d9c9b74 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 0aadac678191..963de5913e50 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
> return err;
> }
>
> -static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
> @@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> return 0;
> }
>
> -static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
>

2021-04-22 02:06:47

by JC Kuo

Subject: Re: [PATCH 1/2] phy: tegra: xusb: annotate PM functions as __maybe_unused

Hi Arnd,
Thanks for the fix.

Reviewed-by: JC Kuo <[email protected]>


On 4/21/21 9:56 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Depending on the configuration, there are no references to these
> two helpers:
>
> drivers/phy/tegra/xusb.c:1286:12: error: 'tegra_xusb_padctl_resume_noirq' defined but not used [-Werror=unused-function]
> 1286 | static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/tegra/xusb.c:1276:12: error: 'tegra_xusb_padctl_suspend_noirq' defined but not used [-Werror=unused-function]
>
> Mark them as __maybe_unused to shut up the warnings without adding
> fragile #ifdefs.
>
> Fixes: b8bb3d9c9b74 ("phy: tegra: xusb: Add sleepwalk and suspend/resume")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/phy/tegra/xusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index 0aadac678191..963de5913e50 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -1273,7 +1273,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev)
> return err;
> }
>
> -static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
> @@ -1283,7 +1283,7 @@ static int tegra_xusb_padctl_suspend_noirq(struct device *dev)
> return 0;
> }
>
> -static int tegra_xusb_padctl_resume_noirq(struct device *dev)
> +static __maybe_unused int tegra_xusb_padctl_resume_noirq(struct device *dev)
> {
> struct tegra_xusb_padctl *padctl = dev_get_drvdata(dev);
>
>