2021-04-21 17:16:54

by Maciej W. Rozycki

Subject: [PATCH] lib/math/test_div64: Fix error message formatting

Align the expected result with one actually produced for easier visual
comparison; this has to take into account what the format specifiers
will actually produce rather than the characters they consist of. E.g.:

test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002
test_div64: ERROR: expected value => 0000000013045e47,00000001

(with a failure induced by setting bit #60 of the divident).

Signed-off-by: Maciej W. Rozycki <[email protected]>
---
lib/math/test_div64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-3maxp-div64/lib/math/test_div64.c
===================================================================
--- linux-3maxp-div64.orig/lib/math/test_div64.c
+++ linux-3maxp-div64/lib/math/test_div64.c
@@ -170,7 +170,7 @@ static inline bool test_div64_verify(u64
if (!test_div64_verify(quotient, remainder, i, j)) { \
pr_err("ERROR: %016llx / %08x => %016llx,%08x\n", \
divident, divisor, quotient, remainder); \
- pr_err("ERROR: expected value=> %016llx,%08x\n", \
+ pr_err("ERROR: expected value => %016llx,%08x\n",\
test_div64_results[i][j].quotient, \
test_div64_results[i][j].remainder); \
result = false; \

2021-04-21 19:06:20

by Thomas Bogendoerfer

Subject: Re: [PATCH] lib/math/test_div64: Fix error message formatting

On Wed, Apr 21, 2021 at 03:25:22PM +0200, Maciej W. Rozycki wrote:
> Align the expected result with one actually produced for easier visual
> comparison; this has to take into account what the format specifiers
> will actually produce rather than the characters they consist of. E.g.:
>
> test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002
> test_div64: ERROR: expected value => 0000000013045e47,00000001
>
> (with a failure induced by setting bit #60 of the divident).
>
> Signed-off-by: Maciej W. Rozycki <[email protected]>
> ---
> lib/math/test_div64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]