Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:
drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
312 | struct pci_dev *rdev;
| ^~~~
Introduced by commit
9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
--
Cheers,
Stephen Rothwell
[AMD Public Use]
Hi, Rothwell
This fix solution hasn't locked down and still being discussed and roll-updated in the NVMe mail group.
Will update the patch once it refined done.
Thanks,
Prike
> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: Friday, April 16, 2021 10:41 AM
> To: Alex Deucher <[email protected]>
> Cc: Liang, Prike <[email protected]>; S-k, Shyam-sundar <Shyam-
> [email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>; Linux Next Mailing List <[email protected]>
> Subject: linux-next: build warning after merge of the amdgpu tree
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-
> variable]
> 312 | struct pci_dev *rdev;
> | ^~~~
>
> Introduced by commit
>
> 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to
> simple suspend/resume path")
>
> --
> Cheers,
> Stephen Rothwell
Hi,
On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <[email protected]> wrote:
>
> Hi, Rothwell
(Stephen, actually :-))
> This fix solution hasn't locked down and still being discussed and roll-updated in the NVMe mail group.
> Will update the patch once it refined done.
In which case, this patch should not be in linux-next (or any branch
that is included by linux-next).
--
Cheers,
Stephen Rothwell
[AMD Public Use]
> From: Stephen Rothwell <[email protected]>
> Sent: Friday, April 16, 2021 12:09 PM
> To: Liang, Prike <[email protected]>
> Cc: Alex Deucher <[email protected]>; S-k, Shyam-sundar <Shyam-
> [email protected]>; Linux Kernel Mailing List <linux-
> [email protected]>; Linux Next Mailing List <[email protected]>
> Subject: Re: linux-next: build warning after merge of the amdgpu tree
>
> Hi,
>
> On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <[email protected]>
> wrote:
> >
> > Hi, Rothwell
>
> (Stephen, actually :-))
>
> > This fix solution hasn't locked down and still being discussed and roll-
> updated in the NVMe mail group.
> > Will update the patch once it refined done.
>
> In which case, this patch should not be in linux-next (or any branch that is
> included by linux-next).
>
How about revert the patch temporally ? Once lock down the solution and will land in the final latest patch.
> --
> Cheers,
> Stephen Rothwell
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike <[email protected]> wrote:
>
> [AMD Public Use]
>
> > From: Stephen Rothwell <[email protected]>
> > Sent: Friday, April 16, 2021 12:09 PM
> > To: Liang, Prike <[email protected]>
> > Cc: Alex Deucher <[email protected]>; S-k, Shyam-sundar <Shyam-
> > [email protected]>; Linux Kernel Mailing List <linux-
> > [email protected]>; Linux Next Mailing List <[email protected]>
> > Subject: Re: linux-next: build warning after merge of the amdgpu tree
> >
> > Hi,
> >
> > On Fri, 16 Apr 2021 03:12:12 +0000 "Liang, Prike" <[email protected]>
> > wrote:
> > >
> > > Hi, Rothwell
> >
> > (Stephen, actually :-))
> >
> > > This fix solution hasn't locked down and still being discussed and roll-
> > updated in the NVMe mail group.
> > > Will update the patch once it refined done.
> >
> > In which case, this patch should not be in linux-next (or any branch that is
> > included by linux-next).
> >
> How about revert the patch temporally ? Once lock down the solution and will land in the final latest patch.
I'll drop it for now. I just have it in there temporarily while it
makes its way upstream because a lot of people use this branch and it
fixes an important bug.
Alex
Hi all,
On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <[email protected]> wrote:
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> 312 | struct pci_dev *rdev;
> | ^~~~
>
> Introduced by commit
>
> 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
I am still seeing this warning.
--
Cheers,
Stephen Rothwell
On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> >
> > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> > 312 | struct pci_dev *rdev;
> > | ^~~~
> >
> > Introduced by commit
> >
> > 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
>
> I am still seeing this warning.
I no longer have that patch in my tree. Was this an old build?
Alex
>
> --
> Cheers,
> Stephen Rothwell
Hi Alex,
On Fri, 23 Apr 2021 16:36:50 -0400 Alex Deucher <[email protected]> wrote:
>
> On Wed, Apr 21, 2021 at 2:40 AM Stephen Rothwell <[email protected]> wrote:
> >
> > On Fri, 16 Apr 2021 12:40:44 +1000 Stephen Rothwell <[email protected]> wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (powerpc
> > > ppc64_defconfig) produced this warning:
> > >
> > > drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> > > drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-variable]
> > > 312 | struct pci_dev *rdev;
> > > | ^~~~
> > >
> > > Introduced by commit
> > >
> > > 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to simple suspend/resume path")
> >
> > I am still seeing this warning.
>
> I no longer have that patch in my tree. Was this an old build?
I guess my email crossed with the patch removal as I not longer get the
warning. Thanks.
--
Cheers,
Stephen Rothwell