2021-04-15 00:05:17

by Stefan Riedmüller

[permalink] [raw]

Subject: [PATCH] leds: pca9532: Assign gpio base dynamically

---

When using devicetree, gpio_base holds its initial zero value which can
lead to a rejection if another gpio controller already occupies this
base. To prevent that collision let the gpio base be assigned dynamically.

Signed-off-by: Stefan Riedmueller <[email protected]>
---
drivers/leds/leds-pca9532.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 27d027165472..017794bb87ae 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -480,6 +480,8 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
if (!pdata)
return ERR_PTR(-ENOMEM);

+ pdata->gpio_base = -1;
+
of_property_read_u8_array(np, "nxp,pwm", &pdata->pwm[0],
ARRAY_SIZE(pdata->pwm));
of_property_read_u8_array(np, "nxp,psc", &pdata->psc[0],
--
2.25.1

2021-04-25 22:04:56

by Pavel Machek

[permalink] [raw]

Subject: Re: [PATCH] leds: pca9532: Assign gpio base dynamically

---

Hi!

> When using devicetree, gpio_base holds its initial zero value which can
> lead to a rejection if another gpio controller already occupies this
> base. To prevent that collision let the gpio base be assigned dynamically.
>
> Signed-off-by: Stefan Riedmueller <[email protected]>

Thanks, applied.
Pavel
--
http://www.livejournal.com/~pavelmachek

---

Attachments:

(No filename) (380.00 B)
signature.asc (188.00 B)
Digital signature Download all attachments