2021-04-26 10:04:06

by Chen-Yu Tsai

[permalink] [raw]
Subject: [PATCH] arm64: dts: rockchip: rk3328: rock-pi-e: Drop fephy pinctrl from gmac2phy

From: Chen-Yu Tsai <[email protected]>

Turns out the fephy pins are already claimed in the phy node, which is
rightfully where they should be claimed.

Drop the pinctrl properties from the gmac2phy node for the ROCK Pi E.

Fixes: b918e81f2145 ("arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E")
Signed-off-by: Chen-Yu Tsai <[email protected]>
---
arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
index 07538951a3a6..018a3a5075c7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts
@@ -177,8 +177,6 @@ rtl8211e: ethernet-phy@1 {
};

&gmac2phy {
- pinctrl-names = "default";
- pinctrl-0 = <&fephyled_linkm1>, <&fephyled_rxm1>;
status = "okay";
};

--
2.31.1


2021-05-09 23:57:21

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: rockchip: rk3328: rock-pi-e: Drop fephy pinctrl from gmac2phy

On Mon, 26 Apr 2021 17:59:16 +0800, Chen-Yu Tsai wrote:
> Turns out the fephy pins are already claimed in the phy node, which is
> rightfully where they should be claimed.
>
> Drop the pinctrl properties from the gmac2phy node for the ROCK Pi E.

Applied, thanks!

[1/1] arm64: dts: rockchip: rk3328: rock-pi-e: Drop fephy pinctrl from gmac2phy
commit: e6526f90696e6a7d722d04b958f15b97d6fd9ce6

Best regards,
--
Heiko Stuebner <[email protected]>