2021-04-28 03:04:26

by Jiabing Wan

[permalink] [raw]
Subject: [PATCH] firmware: psci: Remove unneeded semicolon

Fix the following coccicheck warning:

./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/firmware/psci/psci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
index 64344e84bd63..6e7bac61ba93 100644
--- a/drivers/firmware/psci/psci.c
+++ b/drivers/firmware/psci/psci.c
@@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno)
return -EINVAL;
case PSCI_RET_DENIED:
return -EPERM;
- };
+ }

return -EINVAL;
}
--
2.25.1


2021-04-28 10:15:12

by Lorenzo Pieralisi

[permalink] [raw]
Subject: Re: [PATCH] firmware: psci: Remove unneeded semicolon

On Wed, Apr 28, 2021 at 11:03:24AM +0800, Wan Jiabing wrote:
> Fix the following coccicheck warning:
>
> ./drivers/firmware/psci/psci.c:141:2-3: Unneeded semicolon
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/firmware/psci/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Fixed by a previous posting:

https://lore.kernel.org/lkml/[email protected]

Thank you anyway.

Lorenzo

>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index 64344e84bd63..6e7bac61ba93 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -138,7 +138,7 @@ static int psci_to_linux_errno(int errno)
> return -EINVAL;
> case PSCI_RET_DENIED:
> return -EPERM;
> - };
> + }
>
> return -EINVAL;
> }
> --
> 2.25.1
>