2021-04-25 08:17:38

by Souptick Joarder

Subject: [PATCH v2] usb: cdns3: Corrected comment to align with kernel-doc comment

Minor update in comment.

Signed-off-by: Souptick Joarder <[email protected]>
---
v2:
Updated change logs and address review comment.

drivers/usb/cdns3/cdns3-gadget.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
index 9b1bd41..21f026c 100644
--- a/drivers/usb/cdns3/cdns3-gadget.c
+++ b/drivers/usb/cdns3/cdns3-gadget.c
@@ -484,7 +484,7 @@ static void __cdns3_descmiss_copy_data(struct usb_request *request,
}

/**
- * cdns3_wa2_descmiss_copy_data copy data from internal requests to
+ * cdns3_wa2_descmiss_copy_data - copy data from internal requests to
* request queued by class driver.
* @priv_ep: extended endpoint object
* @request: request object
--
1.9.1

2021-04-25 15:57:09

by Randy Dunlap

Subject: Re: [PATCH v2] usb: cdns3: Corrected comment to align with kernel-doc comment

On 4/25/21 1:16 AM, Souptick Joarder wrote:
> Minor update in comment.
>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---
> v2:
> Updated change logs and address review comment.

LGTM. Thanks.

Acked-by: Randy Dunlap <[email protected]>

> drivers/usb/cdns3/cdns3-gadget.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> index 9b1bd41..21f026c 100644
> --- a/drivers/usb/cdns3/cdns3-gadget.c
> +++ b/drivers/usb/cdns3/cdns3-gadget.c
> @@ -484,7 +484,7 @@ static void __cdns3_descmiss_copy_data(struct usb_request *request,
> }
>
> /**
> - * cdns3_wa2_descmiss_copy_data copy data from internal requests to
> + * cdns3_wa2_descmiss_copy_data - copy data from internal requests to
> * request queued by class driver.
> * @priv_ep: extended endpoint object
> * @request: request object
>


--
~Randy

2021-04-30 03:40:05

by Peter Chen

Subject: Re: [PATCH v2] usb: cdns3: Corrected comment to align with kernel-doc comment

On 21-04-25 08:53:33, Randy Dunlap wrote:
> On 4/25/21 1:16 AM, Souptick Joarder wrote:
> > Minor update in comment.
> >
> > Signed-off-by: Souptick Joarder <[email protected]>
> > ---
> > v2:
> > Updated change logs and address review comment.
>
> LGTM. Thanks.
>
> Acked-by: Randy Dunlap <[email protected]>

Applied, thanks.

Peter

>
> > drivers/usb/cdns3/cdns3-gadget.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c
> > index 9b1bd41..21f026c 100644
> > --- a/drivers/usb/cdns3/cdns3-gadget.c
> > +++ b/drivers/usb/cdns3/cdns3-gadget.c
> > @@ -484,7 +484,7 @@ static void __cdns3_descmiss_copy_data(struct usb_request *request,
> > }
> >
> > /**
> > - * cdns3_wa2_descmiss_copy_data copy data from internal requests to
> > + * cdns3_wa2_descmiss_copy_data - copy data from internal requests to
> > * request queued by class driver.
> > * @priv_ep: extended endpoint object
> > * @request: request object
> >
>
>
> --
> ~Randy
>

--

Thanks,
Peter Chen