2021-04-30 09:25:04

by Heiko Schocher

[permalink] [raw]

Subject: [PATCH] usb: dwc3: imx8mp: detect dwc3 child nodes with name "usb*"

---

commit:
d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")

renamed "dwc3@3*" nodes in imx8mp.dtsi to "usb@3*"

glue layer dwc3-imx8mp.c searches for "dwc3" and so drop failure
on boot:
imx8mp-dwc3 32f10100.usb: failed to find dwc3 core child
imx8mp-dwc3: probe of 32f10100.usb failed with error 1
imx8mp-dwc3 32f10108.usb: failed to find dwc3 core child
imx8mp-dwc3: probe of 32f10108.usb failed with error 1

now. Fix this (and allow old style too)

Tested on "PHYTEC phyBOARD-Pollux i.MX8MP" board.

fixes: d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")
Signed-off-by: Heiko Schocher <[email protected]>
---

drivers/usb/dwc3/dwc3-imx8mp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index b13cfab89d532..eb85ddc50f7c7 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -165,7 +165,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
if (err < 0)
goto disable_rpm;

- dwc3_np = of_get_child_by_name(node, "dwc3");
+ dwc3_np = of_get_child_by_name(node, "usb") ? :
+ of_get_child_by_name(node, "dwc3");
if (!dwc3_np) {
dev_err(dev, "failed to find dwc3 core child\n");
goto disable_rpm;
--
2.30.2

2021-04-30 10:05:03

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: imx8mp: detect dwc3 child nodes with name "usb*"

---

Heiko Schocher <[email protected]> writes:

> commit:
> d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")
>
> renamed "dwc3@3*" nodes in imx8mp.dtsi to "usb@3*"
>
> glue layer dwc3-imx8mp.c searches for "dwc3" and so drop failure
> on boot:
> imx8mp-dwc3 32f10100.usb: failed to find dwc3 core child
> imx8mp-dwc3: probe of 32f10100.usb failed with error 1
> imx8mp-dwc3 32f10108.usb: failed to find dwc3 core child
> imx8mp-dwc3: probe of 32f10108.usb failed with error 1
>
> now. Fix this (and allow old style too)
>
> Tested on "PHYTEC phyBOARD-Pollux i.MX8MP" board.
>
> fixes: d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")
> Signed-off-by: Heiko Schocher <[email protected]>

already sent, see https://lore.kernel.org/r/[email protected]

--
balbi

---

Attachments:

signature.asc (521.00 B)

2021-04-30 10:17:05

by Heiko Schocher

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: imx8mp: detect dwc3 child nodes with name "usb*"

---

Hi Felipe,

On 30.04.21 12:03, Felipe Balbi wrote:
> Heiko Schocher <[email protected]> writes:
>
>> commit:
>> d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")
>>
>> renamed "dwc3@3*" nodes in imx8mp.dtsi to "usb@3*"
>>
>> glue layer dwc3-imx8mp.c searches for "dwc3" and so drop failure
>> on boot:
>> imx8mp-dwc3 32f10100.usb: failed to find dwc3 core child
>> imx8mp-dwc3: probe of 32f10100.usb failed with error 1
>> imx8mp-dwc3 32f10108.usb: failed to find dwc3 core child
>> imx8mp-dwc3: probe of 32f10108.usb failed with error 1
>>
>> now. Fix this (and allow old style too)
>>
>> Tested on "PHYTEC phyBOARD-Pollux i.MX8MP" board.
>>
>> fixes: d1689cd3c0f4: ("arm64: dts: imx8mp: Use the correct name for child node "snps, dwc3")
>> Signed-off-by: Heiko Schocher <[email protected]>
>
> already sent, see https://lore.kernel.org/r/[email protected]

Ah, great. Missed this patch, thanks!

So, please forget this patch.

bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]