2021-05-04 02:45:02

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] MFD: mp2629: select MFD_CORE to fix build error

MFD_MP2629 should select MFD_CORE to a prevent build error:

ERROR: modpost: "devm_mfd_add_devices" [drivers/mfd/mp2629.ko] undefined!

Fixes: 06081646450e ("mfd: mp2629: Add support for mps battery charger")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Saravanan Sekar <[email protected]>
Cc: Lee Jones <[email protected]>
---
drivers/mfd/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20210503.orig/drivers/mfd/Kconfig
+++ linux-next-20210503/drivers/mfd/Kconfig
@@ -465,6 +465,7 @@ config MFD_MP2629
tristate "Monolithic Power Systems MP2629 ADC and Battery charger"
depends on I2C
select REGMAP_I2C
+ select MFD_CORE
help
Select this option to enable support for Monolithic Power Systems
battery charger. This provides ADC, thermal and battery charger power


2021-05-10 16:15:13

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] MFD: mp2629: select MFD_CORE to fix build error

On Mon, 03 May 2021, Randy Dunlap wrote:

> MFD_MP2629 should select MFD_CORE to a prevent build error:
>
> ERROR: modpost: "devm_mfd_add_devices" [drivers/mfd/mp2629.ko] undefined!
>
> Fixes: 06081646450e ("mfd: mp2629: Add support for mps battery charger")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Saravanan Sekar <[email protected]>
> Cc: Lee Jones <[email protected]>
> ---
> drivers/mfd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog