2021-05-05 12:05:38

by David Sterba

[permalink] [raw]
Subject: Re: [PATCH 22/35] tty: make tty_operations::write_room return uint

On Wed, May 05, 2021 at 11:19:15AM +0200, Jiri Slaby wrote:
> Line disciplines expect a positive value or zero returned from
> tty->ops->write_room (invoked by tty_write_room). So make this
> assumption explicit by using unsigned int as a return value. Both of
> tty->ops->write_room and tty_write_room.
>
> Signed-off-by: Jiri Slaby <[email protected]>
> Cc: Richard Henderson <[email protected]>
> Cc: Ivan Kokshaysky <[email protected]>
> Cc: Matt Turner <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: "James E.J. Bottomley" <[email protected]>
> Cc: Helge Deller <[email protected]>
> Cc: Jeff Dike <[email protected]>
> Cc: Richard Weinberger <[email protected]>
> Cc: Anton Ivanov <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: Max Filippov <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Samuel Iglesias Gonsalvez <[email protected]>
> Cc: Jens Taprogge <[email protected]>
> Cc: Karsten Keil <[email protected]>
> Cc: Scott Branden <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Vasily Gorbik <[email protected]>
> Cc: Christian Borntraeger <[email protected]>
> Cc: David Lin <[email protected]>
> Cc: Johan Hovold <[email protected]>
> Cc: Alex Elder <[email protected]>
> Cc: Laurentiu Tudor <[email protected]>
> Cc: Jiri Kosina <[email protected]>
> Cc: David Sterba <[email protected]>
> Cc: Shawn Guo <[email protected]>
> Cc: Sascha Hauer <[email protected]>
> Cc: Oliver Neukum <[email protected]>
> Cc: Felipe Balbi <[email protected]>
> Cc: Mathias Nyman <[email protected]>
> Cc: Marcel Holtmann <[email protected]>
> Cc: Johan Hedberg <[email protected]>
> Cc: Luiz Augusto von Dentz <[email protected]>
> ---
> drivers/tty/ipwireless/tty.c | 2 +-

Acked-by: David Sterba <[email protected]>