2021-05-06 04:04:02

by Jim Cromie

[permalink] [raw]
Subject: [PATCH 4/4] module: reduce already_uses pr_debug verbosity

already_uses() is unnecessarily chatty. For example,
`modprobe i915` yields 491 messages like:

[ 64.108744] i915 uses drm!

This is a normal situation, and isn't worth all the log entries. The
!found pr_debug is kept, its more of an exceptional condition, and
seems worth a pr_debug. I haven't seen it happen.

Signed-off-by: Jim Cromie <[email protected]>
---
kernel/module.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index c3333b45d812..dc1eda39ba96 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -772,10 +772,8 @@ static int already_uses(struct module *a, struct module *b)
struct module_use *use;

list_for_each_entry(use, &b->source_list, source_list) {
- if (use->source == a) {
- pr_debug("%s uses %s!\n", a->name, b->name);
+ if (use->source == a)
return 1;
- }
}
pr_debug("%s does not use %s!\n", a->name, b->name);
return 0;
--
2.30.2