2021-05-06 08:27:14

by Chunfeng Yun

[permalink] [raw]

Subject: [PATCH] usb: dwc3: remove repeated setting of current_dr_role

---

dwc3_set_prtcap() already sets current_dr_role as
DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.

Signed-off-by: Chunfeng Yun <[email protected]>
---
drivers/usb/dwc3/drd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index e2b68bb770d1..8fcbac10510c 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -596,7 +596,6 @@ int dwc3_drd_init(struct dwc3 *dwc)
dwc3_drd_update(dwc);
} else {
dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
- dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;

/* use OTG block to get ID event */
irq = dwc3_otg_get_irq(dwc);
--
2.18.0

2021-05-06 08:59:33

by Felipe Balbi

[permalink] [raw]

Subject: Re: [PATCH] usb: dwc3: remove repeated setting of current_dr_role

---

Hi,

Chunfeng Yun <[email protected]> writes:
> dwc3_set_prtcap() already sets current_dr_role as
> DWC3_GCTL_PRTCAP_OTG, so remove the repeated one.
>
> Signed-off-by: Chunfeng Yun <[email protected]>

looks correct to me:

Acked-by: Felipe Balbi <[email protected]>

--
balbi

---

Attachments:

signature.asc (521.00 B)