2021-05-07 17:04:35

by Hsin-Yi Wang

Subject: [PATCH v21 3/5] i2c: mediatek: mt65xx: add optional vbus-supply

Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..22d1d14b5de5 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }

ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.607.g51e8a6a459-goog

2021-05-12 17:42:10

by Matthias Brugger

Subject: Re: [PATCH v21 3/5] i2c: mediatek: mt65xx: add optional vbus-supply

On 07/05/2021 15:14, Hsin-Yi Wang wrote:
> Add vbus-supply which provides power to SCL/SDA. Pass this regulator
> into core so it can be turned on/off for low power mode support.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 5ddfa4e56ee2..22d1d14b5de5 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> i2c->adap.quirks = i2c->dev_comp->quirks;
> i2c->adap.timeout = 2 * HZ;
> i2c->adap.retries = 1;
> + i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
> + if (IS_ERR(i2c->adap.bus_regulator)) {
> + if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
> + i2c->adap.bus_regulator = NULL;
> + else
> + return PTR_ERR(i2c->adap.bus_regulator);
> + }
>
> ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
> if (ret)
>

2021-05-17 08:14:56

by Qii Wang (王琪)

Subject: Re: [PATCH v21 3/5] i2c: mediatek: mt65xx: add optional vbus-supply

On Fri, 2021-05-07 at 21:14 +0800, Hsin-Yi Wang wrote:
> Add vbus-supply which provides power to SCL/SDA. Pass this regulator
> into core so it can be turned on/off for low power mode support.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: Qii Wang <[email protected]>

> ---
> drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 5ddfa4e56ee2..22d1d14b5de5 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
> @@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> i2c->adap.quirks = i2c->dev_comp->quirks;
> i2c->adap.timeout = 2 * HZ;
> i2c->adap.retries = 1;
> + i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
> + if (IS_ERR(i2c->adap.bus_regulator)) {
> + if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
> + i2c->adap.bus_regulator = NULL;
> + else
> + return PTR_ERR(i2c->adap.bus_regulator);
> + }
>
> ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
> if (ret)